Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for RFC 2627: #[link(kind="raw-dylib")] #58713

Open
joshtriplett opened this issue Feb 24, 2019 · 3 comments
Open

Tracking issue for RFC 2627: #[link(kind="raw-dylib")] #58713

joshtriplett opened this issue Feb 24, 2019 · 3 comments

Comments

@joshtriplett
Copy link
Member

@joshtriplett joshtriplett commented Feb 24, 2019

This is the tracking issue for RFC 2627, #[link(kind="raw-dylib")].

Opens:

  • Implementation for Windows (top priority)
    • Emitting idata sections
    • New link_ordinal attribute
    • Testing in winapi with nightly Rust before stabilization
  • Tests, including all the corner cases mentioned in the reference-level explanation
  • Documentation
  • Implementation for Linux and other platforms
  • Implementation of a pure Rust target for Windows (no libc, no msvc, no mingw). This may require another RFC
joshtriplett added a commit to rust-lang/rfcs that referenced this issue Feb 24, 2019
🎉 RFC 2627 is now `#[link(kind="raw-dylib")]`! 🎉

Tracking issue: rust-lang/rust#58713
@Centril Centril added the T-lang label Feb 25, 2019
@crlf0710

This comment has been minimized.

Copy link
Contributor

@crlf0710 crlf0710 commented Feb 27, 2019

@ZerothLaw

This comment has been minimized.

Copy link

@ZerothLaw ZerothLaw commented Mar 2, 2019

I don't think I have the expertise to implement this feature, but I could write some (currently failing) tests for use by the implementor?

(Background, Ran into this exact problem linking mscorlib.dll into executables. Had to write a C++ level wrapper to get it to work.)

@Centril Centril added the F-raw_dylib label Aug 27, 2019
Centril added a commit to Centril/rust that referenced this issue Sep 20, 2019
Add feature gate for raw_dylib.

This PR adds the feature gate for RFC 2627 (rust-lang#58713). It doesn't contain the actual functionality.
Add I'm not sure whether i did it correctly, since this is the first time i did this.

r? @Centril
bors added a commit that referenced this issue Sep 20, 2019
Add feature gate for raw_dylib.

This PR adds the feature gate for RFC 2627 (#58713). It doesn't contain the actual functionality.
Add I'm not sure whether i did it correctly, since this is the first time i did this.

r? @Centril
bors added a commit that referenced this issue Sep 22, 2019
Add feature gate for raw_dylib.

This PR adds the feature gate for RFC 2627 (#58713). It doesn't contain the actual functionality.
Add I'm not sure whether i did it correctly, since this is the first time i did this.

r? @Centril
Centril added a commit to Centril/rust that referenced this issue Oct 7, 2019
Add feature gate for raw_dylib.

This PR adds the feature gate for RFC 2627 (rust-lang#58713). It doesn't contain the actual functionality.
Add I'm not sure whether i did it correctly, since this is the first time i did this.

r? @Centril
@crlf0710

This comment has been minimized.

Copy link
Contributor

@crlf0710 crlf0710 commented Oct 8, 2019

A very first PR has landed, now the link_ordinal attribute is added. Want to say thank you to @Centril for helping me on this~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.