Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to termcolor (first)? #60349

Open
crlf0710 opened this issue Apr 28, 2019 · 2 comments
Open

Switch to termcolor (first)? #60349

crlf0710 opened this issue Apr 28, 2019 · 2 comments
Labels
A-libtest Area: #[test] related C-enhancement Category: An issue proposing an enhancement or a PR with one. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@crlf0710
Copy link
Member

There're on going effort to move libtest out of tree, however i think the current approach(#59440) is a little too aggressive by changing everything in a huge PR. I think it the effort should be splitted and happen in several separate steps.

The first big step in it is replacing libterm with termcolor, which means:

  • Add separate features to termcolor, wincolor, and winapi to mark these crates unstable (so they can be shipped with rustc.
  • Maybe move these crates repo to rust-lang organization.
  • Modify libtest in-tree to use termcolor

An alternative is to keep the existing code for unstable rustc usage but make it a shim over termcolor for non-rustc usages.

Just wrote these down to see what peoples think. @alexcrichton @Manishearth @gnzlbg @BurntSushi
@Centril Centril added the A-libtest Area: #[test] related label Apr 29, 2019
@euclio euclio mentioned this issue Aug 20, 2019
Closed
@euclio
Copy link
Contributor

euclio commented Nov 12, 2019 •
edited
Loading

I'm working on this. I have local builds of the aforementioned crates that allows completely migrating over to termcolor.

I've opened retep998/winapi-rs#831 as a first step, but it's blocked until winapi can upgrade its MSRV in 0.4.

Also, as mentioned in #63725, we'll need to fix kennytm/fwdansi#1 before upgrading the termcolor version.

@euclio euclio mentioned this issue Jan 9, 2020
Merged
@crlf0710
Copy link
Member Author

As an inferior alternative, I have a fork of termcolor at https://github.com/crlf0710/termcolor, where winapi dependency is removed. Feel free to cherry-pick anything that's usefu to you.

Centril added a commit to Centril/rust that referenced this issue Jan 12, 2020
@Centril
Rollup merge of rust-lang#68036 - euclio:libterm-ncurses6-fix, r=KodrAus
1abb7e9 
libterm: parse extended terminfo format

Fixes rust-lang#45728.

Modifies libterm to parse the extended terminfo format introduced in ncurses 6.1. This fixes the lack of color in test output for users with newer ncurses versions.

The ideal fix for this would be to migrate libtest to use `termcolor` (rust-lang#60349), but that's blocked for the foreseeable future.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Jan 13, 2020
@Dylan-DPC
Rollup merge of rust-lang#68036 - euclio:libterm-ncurses6-fix, r=KodrAus
1153403 
libterm: parse extended terminfo format

Fixes rust-lang#45728.

Modifies libterm to parse the extended terminfo format introduced in ncurses 6.1. This fixes the lack of color in test output for users with newer ncurses versions.

The ideal fix for this would be to migrate libtest to use `termcolor` (rust-lang#60349), but that's blocked for the foreseeable future.
JohnTitor added a commit to JohnTitor/rust that referenced this issue Jan 14, 2020
@JohnTitor
Rollup merge of rust-lang#68036 - euclio:libterm-ncurses6-fix, r=KodrAus
974b699 
libterm: parse extended terminfo format

Fixes rust-lang#45728.

Modifies libterm to parse the extended terminfo format introduced in ncurses 6.1. This fixes the lack of color in test output for users with newer ncurses versions.

The ideal fix for this would be to migrate libtest to use `termcolor` (rust-lang#60349), but that's blocked for the foreseeable future.
@jonas-schievink jonas-schievink added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-libtest Area: #[test] related C-enhancement Category: An issue proposing an enhancement or a PR with one. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
testing-devex backlog
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace libterm with termcolor in libtest euclio/rust
4 participants
@crlf0710 @Centril @euclio @jonas-schievink