Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String encoding/decoding and I/O #6164

Closed
brson opened this issue May 2, 2013 · 9 comments
Closed

String encoding/decoding and I/O #6164

brson opened this issue May 2, 2013 · 9 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. P-medium Medium priority

Comments

@brson
Copy link
Contributor

brson commented May 2, 2013

How do we deal with string encoding of I/O? The existing implementation uses extension methods on Readers and Writers, but this is not sufficient because it doesn't maintain any state. Need a better understanding of the requirements here.
@ghost ghost assigned brson May 2, 2013
This was referenced May 2, 2013
Closed
Closed
@graydon graydon mentioned this issue Jun 19, 2013
Closed
@brson brson mentioned this issue Jul 28, 2013
Closed
@huonw huonw mentioned this issue Sep 10, 2013
Closed
@alexcrichton
Copy link
Member

Nominating, we need to deal with this.

@brson
Copy link
Contributor Author

brson commented Oct 30, 2013

Big thread an this subject https://mail.mozilla.org/pipermail/rust-dev/2013-September/005503.html

@brson brson closed this as completed Oct 30, 2013
@brson brson reopened this Oct 30, 2013
@klutzy
Copy link
Contributor

klutzy commented Oct 31, 2013

api proposal: https://github.com/mozilla/rust/wiki/Proposal-for-character-encoding-API

@pnkfelix
Copy link
Member

pnkfelix commented Nov 7, 2013

accepted for 1.0 in that we to at least define our story around this. documentation if nothing else.

@erickt erickt mentioned this issue Dec 2, 2013
Open
@pnkfelix pnkfelix mentioned this issue Jan 28, 2014
Closed
@brson brson removed their assignment Feb 10, 2014
@brson
Copy link
Contributor Author

brson commented Feb 17, 2014

Last time @alexcrichton and I talked about this we concurred that encoding could be left to other libraries, and we don't need to explicitly solve this for 1.0.

@brson
Copy link
Contributor Author

brson commented Feb 17, 2014

Nominating for removal from milestone.

@pnkfelix
Copy link
Member

Removing from 1.0, P-high

@pnkfelix pnkfelix removed this from the 1.0 milestone Feb 27, 2014
@alexcrichton
Copy link
Member

cc @aturon

@brson
Copy link
Contributor Author

brson commented Jan 13, 2015

Assuming this is not very relevant these days.

@brson brson closed this as completed Jan 13, 2015
flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 8, 2021
@bors
Auto merge of rust-lang#7020 - camsteffen:needless-collect, r=Manishe…
86fb0e8 
…arth

Improve needless_collect output

changelog: Improve needless_collect output

Fixes rust-lang#6908
Partially addresses rust-lang#6164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. P-medium Medium priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexcrichton @brson @pnkfelix @klutzy