Fix #7013 by treating owned closures and traits as non-Const #7020
Conversation
Owned traits and closures can contain any type, including those that do not satisfy Const, and thus must not satisfy Const themselves.
|
I r+'d this because it seems reasonable, but I know there are pending changes to the language here. Maybe @nikomatsakis or @catamorphism can take a peek. |
|
Thanks! |
|
This change is ok, it's just not the full fix that will eventually be required (which is to consider the declared bounds of the closure; but also to remove owned closures altogether, at least if we stick with current plan). |
|
@bill-myers needs a rebase |
|
I'll rebase and reopen this tomorrow morning. |
|
@nikomatsakis @catamorphism so rebasing this I came across the problem that TC_OWNED_CLOSURE has been removed from middle::ty entirely. I'm going to reopen, because I don't know enough to fix this. |
|
#7013 seems to be fixed now; I added the test case as a commit in #8570. I'm closing this -- thanks for your effort, @bill-myers ! |
…arth Improve needless_collect output changelog: Improve needless_collect output Fixes rust-lang#6908 Partially addresses rust-lang#6164
Fix #7013: the idea is that they can include arbitrary types, which may not be Const.
I'm not totally sure this is conceptually correct and catches all cases, please check.