Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase test coverage for async-await #62121

Open
nikomatsakis opened this issue Jun 25, 2019 · 3 comments

Comments

Projects
None yet
4 participants
@nikomatsakis
Copy link
Contributor

commented Jun 25, 2019

As part of the async-await feature we want to make sure we have good test coverage. We have a master list of tests prepared by @cramertj and @Centril that we'd like to complete.

@cramertj

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

#62106 is a first step towards this.

@Centril

This comment has been minimized.

Copy link
Member

commented Jun 28, 2019

Centril added a commit to Centril/rust that referenced this issue Jun 30, 2019

Rollup merge of rust-lang#62241 - Centril:fix-async-unsafe-order, r=p…
…etrochenkov

Always parse 'async unsafe fn' + properly ban in 2015

Parse `async unsafe fn` not `unsafe async fn` in implementations. We also take the opportunity to properly ban `async fn` in Rust 2015 when they are inside implementations.

Closes rust-lang#62232.

cc rust-lang#61319, rust-lang#62121, and rust-lang#62149.

r? @petrochenkov

Centril added a commit to Centril/rust that referenced this issue Jul 5, 2019

Rollup merge of rust-lang#62193 - matthewjasper:dynamic-drop-async, r…
…=Centril

Create async version of the dynamic-drop test

Some of the tests in dynamic-drop have been cut:
* The tests that are just simpler versions of other tests - these tests are already fairly slow due to all of the unwinding and async functions have more control flow paths than normal functions.
* The union test - it's for an unstable feature that has an RFC to remove it.
* The generator test - there aren't async generators yet.
* The tests that show values being leaked - these can be added once the issue is fixed.

r? @Centril
cc  rust-lang#62121 @cramertj

Centril added a commit to Centril/rust that referenced this issue Jul 5, 2019

Rollup merge of rust-lang#62193 - matthewjasper:dynamic-drop-async, r…
…=Centril

Create async version of the dynamic-drop test

Some of the tests in dynamic-drop have been cut:
* The tests that are just simpler versions of other tests - these tests are already fairly slow due to all of the unwinding and async functions have more control flow paths than normal functions.
* The union test - it's for an unstable feature that has an RFC to remove it.
* The generator test - there aren't async generators yet.
* The tests that show values being leaked - these can be added once the issue is fixed.

r? @Centril
cc  rust-lang#62121 @cramertj

Centril added a commit to Centril/rust that referenced this issue Jul 5, 2019

Rollup merge of rust-lang#62193 - matthewjasper:dynamic-drop-async, r…
…=Centril

Create async version of the dynamic-drop test

Some of the tests in dynamic-drop have been cut:
* The tests that are just simpler versions of other tests - these tests are already fairly slow due to all of the unwinding and async functions have more control flow paths than normal functions.
* The union test - it's for an unstable feature that has an RFC to remove it.
* The generator test - there aren't async generators yet.
* The tests that show values being leaked - these can be added once the issue is fixed.

r? @Centril
cc  rust-lang#62121 @cramertj
@delan

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

as discussed in #62518, I can do some async unsafe fn tests starting with

  • Check that an async unsafe fn requires unsafe { ... } to be called.
    • Including async unsafe fn implementations...
  • Tangentially also test the behavior of unsafe { async { $stuff } } wrt. allowing unsafe operations in $stuff.

Centril added a commit to Centril/rust that referenced this issue Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.