Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deconstructing pointer to tuple in arguments causes ICE #6557

Closed
DoctorAlpaca opened this issue May 17, 2013 · 1 comment
Closed

Deconstructing pointer to tuple in arguments causes ICE #6557

DoctorAlpaca opened this issue May 17, 2013 · 1 comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added.

Comments

@DoctorAlpaca
Copy link

This function crashes the compiler:

fn foo(~(x, y): ~(int, int)) {}

Output:

error: internal compiler error: node_id_to_type: no type for node `unknown node (id=3)`

Using & or @ pointers does the same thing.
@emberian
Copy link
Member

emberian commented Aug 5, 2013

This now works. Needs a test.

@alexcrichton alexcrichton mentioned this issue Aug 13, 2013
Closed
bors added a commit that referenced this issue Aug 15, 2013
@bors
auto merge of #8485 : alexcrichton/rust/add-tests, r=catamorphism
c4656cf 
Closes #3907
Closes #5493
Closes #4464
Closes #4759
Closes #5666
Closes #5884
Closes #5926
Closes #6318
Closes #6557
Closes #6898
Closes #6919
Closes #7222
flip1995 pushed a commit to flip1995/rust that referenced this issue Jan 15, 2021
@bors
Auto merge of rust-lang#6557 - rail-rain:extending_cast_ptr_alignment…
7f4599a 
…, r=phansch

Catch `pointer::cast` too in `cast_ptr_alignment`

Fixes rust-lang#4708

Although there were some discussion in the issue, this PR implements the original feature. I think `cast_ptr_alignment` should exist as it is, separated from `ptr_as_ptr`.

---

changelog: Extend `cast_ptr_alignment` lint for the `pointer::cast` method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a bunch of tests for closed issues alexcrichton/rust
2 participants
@emberian @DoctorAlpaca