Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong deprecation version in Error::description #69751

Closed
est31 opened this issue Mar 6, 2020 · 4 comments · Fixed by #69754
Closed

wrong deprecation version in Error::description #69751

est31 opened this issue Mar 6, 2020 · 4 comments · Fixed by #69754
Labels
C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@est31
Copy link
Member

est31 commented Mar 6, 2020

#66919 has added #[rustc_deprecated(since = "1.41.0")] to Error::description but the PR made it only into Rust 1.42.0. Thus the version number should be adjusted. cc @dtolnay
@est31 est31 added the C-bug Category: This is a bug. label Mar 6, 2020
@Mark-Simulacrum Mark-Simulacrum added the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label Mar 6, 2020
@Mark-Simulacrum
Copy link
Member

We would be happy to accept a PR for this. I suppose it's a trivial enough fix that I would even be willing to backport it (so we avoid 1.42 indicating incorrectly), but only if we get it in quickly enough.

cc @pietroalbini re:backport, since you're doing release

@est31
Copy link
Member Author

est31 commented Mar 6, 2020

I won't do it but it should be easy enough.

@dylnuge dylnuge mentioned this issue Mar 6, 2020
Merged
@dylnuge
Copy link
Contributor

dylnuge commented Mar 6, 2020 •
edited
Loading

I just made a PR for updating this; this is my first contribution to the project (please let me know if I did the process right). Hope that helps!

@steveklabnik
Copy link
Member

I just noticed this and saw a PR already existed, amazing! 👍 to a backport.

Centril added a commit to Centril/rust that referenced this issue Mar 7, 2020
@Centril
Rollup merge of rust-lang#69754 - Dylnuge:dylnuge/dep-version, r=Mark…
49eae8a 
…-Simulacrum

Update deprecation version to 1.42 for Error::description

Error::description is deprecated as of version 1.42, as the commit was
not in the release for 1.41.

Fixes rust-lang#69751
@bors bors closed this as completed in ca90c3d Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update deprecation version to 1.42 for Error::description dylnuge/rust
4 participants
@steveklabnik @dylnuge @Mark-Simulacrum @est31