Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecation version to 1.42 for Error::description #69754

Merged
merged 1 commit into from
Mar 7, 2020

Conversation

dylnuge
Copy link
Contributor

@dylnuge dylnuge commented Mar 6, 2020

Error::description is deprecated as of version 1.42, as the commit was
not in the release for 1.41.

Fixes #69751

Error::description is deprecated as of version 1.42, as the commit was
not in the release for 1.41.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cramertj (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 6, 2020
@pietroalbini pietroalbini added beta-nominated Nominated for backporting to the compiler in the beta channel. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Mar 6, 2020
@pietroalbini
Copy link
Member

r? @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 6, 2020

📌 Commit 9afbf28 has been approved by Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Mar 6, 2020

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2020
@pietroalbini
Copy link
Member

Ping @rust-lang/libs, this needs to be beta-accepted in the next 3 days if you want to include it in stable 1.42.0.

@sfackler
Copy link
Member

sfackler commented Mar 6, 2020

IMO that's more up to how the release folks feel about landing more backports. It seems pretty low risk, but also fairly low benefit.

@pietroalbini
Copy link
Member

If you say it's low risk we can just bundle it in the stable promotion PR.

@Mark-Simulacrum Mark-Simulacrum added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 6, 2020
@Mark-Simulacrum
Copy link
Member

I'm marking as beta accepted, it's a trivial change.

Centril added a commit to Centril/rust that referenced this pull request Mar 7, 2020
…-Simulacrum

Update deprecation version to 1.42 for Error::description

Error::description is deprecated as of version 1.42, as the commit was
not in the release for 1.41.

Fixes rust-lang#69751
bors added a commit that referenced this pull request Mar 7, 2020
Rollup of 9 pull requests

Successful merges:

 - #67741 (When encountering an Item in a pat context, point at the item def)
 - #68985 (Parse & reject postfix operators after casts)
 - #69656 (Use .next() instead of .nth(0) on iterators.)
 - #69680 (rustc_expand: Factor out `Annotatable::into_tokens` to a separate method)
 - #69690 (test(pattern): add tests for combinations of pattern features)
 - #69706 (Use subslice patterns in slice methods)
 - #69727 (Avoid using `unwrap()` in suggestions)
 - #69754 (Update deprecation version to 1.42 for Error::description)
 - #69782 (Don't redundantly repeat field names (clippy::redundant_field_names))

Failed merges:

r? @ghost
@bors bors merged commit ca90c3d into rust-lang:master Mar 7, 2020
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 9, 2020
bors added a commit that referenced this pull request Mar 9, 2020
[stable] Release 1.42.0

This PR prepares the release artifacts of Rust 1.42.0, and cherry-picks the following PRs:

* #69754: Update deprecation version to 1.42 for Error::description
* #69753: Do not ICE when matching an uninhabited enum's field
* #69522 / #69853: error_derive_forbidden_on_non_adt: be more graceful
* #68598:  Fix null synthetic_implementors error

In addition, the release notes are updated to include the remaining compatibility notes.

r? @Centril
bors added a commit that referenced this pull request Mar 9, 2020
[stable] Release 1.42.0

This PR prepares the release artifacts of Rust 1.42.0, and cherry-picks the following PRs:

* #69754: Update deprecation version to 1.42 for Error::description
* #69753: Do not ICE when matching an uninhabited enum's field
* #69522 / #69853: error_derive_forbidden_on_non_adt: be more graceful
* #68598:  Fix null synthetic_implementors error

In addition, the release notes are updated to include the remaining compatibility notes.

r? @Centril
@dylnuge dylnuge deleted the dylnuge/dep-version branch March 11, 2020 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong deprecation version in Error::description
7 participants