Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for feature future_poll_fn #72302

Open
2 tasks
yoshuawuyts opened this issue May 17, 2020 · 2 comments
Open
2 tasks

Tracking Issue for feature future_poll_fn #72302

yoshuawuyts opened this issue May 17, 2020 · 2 comments
Labels
A-async-await AsyncAwait-Triaged B-unstable C-tracking-issue disposition-merge Libs-Tracked proposed-final-comment-period T-libs-api

Comments

@yoshuawuyts
Copy link
Member

@yoshuawuyts yoshuawuyts commented May 17, 2020

The feature gate for the issue is #![feature(future_poll_fn)].

Steps

Unresolved Questions

  • Should this be named future::from_fn instead?

Implementation history

  • Initial implementation in #72303
  • Rename from future::poll_fn to future::from_fn in #76789
    • closed as it's ambiguous, see the discussion on that PR
@yoshuawuyts yoshuawuyts added the C-tracking-issue label May 17, 2020
@jonas-schievink jonas-schievink added A-async-await B-unstable T-libs-api labels May 17, 2020
@tmandry tmandry added the AsyncAwait-Triaged label May 19, 2020
@KodrAus KodrAus added the Libs-Tracked label Jul 29, 2020
@joshtriplett
Copy link
Member

@joshtriplett joshtriplett commented Jun 20, 2022

This exists in futures-lite, and people use it. It seems worth having available in the standard library.

The naming discussion doesn't seem likely to change, and all else being equal there's a history for the name poll_fn.

Shall we stabilize this?

@rfcbot merge

@rfcbot
Copy link

@rfcbot rfcbot commented Jun 20, 2022

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period disposition-merge labels Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-async-await AsyncAwait-Triaged B-unstable C-tracking-issue disposition-merge Libs-Tracked proposed-final-comment-period T-libs-api
Projects
None yet
Development

No branches or pull requests

6 participants