-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
miri
no longer builds after rust-lang/rust#73441
#74484
Comments
I don't think we can resolve this until #74506 is fixed, as we can't build a libstd anymore :( |
However, that cannot be the only problem -- Miri also fails to build in-tree:
@alexcrichton any idea why those might be missing? |
|
Ah this is my mistake, I didn't check that libstd still compiled without the |
Just please make sure to also include it in rust-src then :) |
This should hopefully handle rust-lang#74484 but in any case fixes compilation of the standard library without the `backtrace` feature. The need for this feature is somewhat unclear now because the `backtrace` crate should always compile (no more C code!) but we can handle that later if necessary.
I'm hoping this will be fixed by #74540 |
…rk-Simulacrum std: Fix compilation without backtrace feature This should hopefully handle rust-lang#74484 but in any case fixes compilation of the standard library without the `backtrace` feature. The need for this feature is somewhat unclear now because the `backtrace` crate should always compile (no more C code!) but we can handle that later if necessary.
…-Simulacrum std: Fix compilation without backtrace feature This should hopefully handle rust-lang#74484 but in any case fixes compilation of the standard library without the `backtrace` feature. The need for this feature is somewhat unclear now because the `backtrace` crate should always compile (no more C code!) but we can handle that later if necessary.
You can test that via 'x.py test --stage 0 src/tools/miri'
|
That indeed solved the libstd build issue, at least for in-tree builds. Now the problem is
Previously, disabling the |
Interestingly, |
rust-lang/backtrace-rs#360 should help (and that's way easier than finding all the methods we have to stub, in particular on Windows). |
Backtraces are unconditionally generated on double panics, and some reshuffling of the crate itself probably meant that |
Hello, this is your friendly neighborhood mergebot.
After merging PR #73441, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.
cc @alexcrichton, do you think you would have time to do the follow-up work?
If so, that would be great!
And nominating for compiler team prioritization.
The text was updated successfully, but these errors were encountered: