Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Search results have larger margins than before #82542

Closed
camelid opened this issue Feb 26, 2021 · 5 comments · Fixed by #82549
Closed

rustdoc: Search results have larger margins than before #82542

camelid opened this issue Feb 26, 2021 · 5 comments · Fixed by #82549
Labels
A-rustdoc-search Area: Rustdoc's search feature A-rustdoc-ui Area: rustdoc UI (generated HTML) regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@camelid
Copy link
Member

camelid commented Feb 26, 2021

nightly (2021-02-25)

image

beta (1.51.0-beta.3)

image
@camelid camelid added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. A-rustdoc-ui Area: rustdoc UI (generated HTML) A-rustdoc-search Area: Rustdoc's search feature labels Feb 26, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Feb 26, 2021
@camelid
Copy link
Member Author

camelid commented Feb 26, 2021 •
edited
Loading

Pretty sure this happened in the last day or two because otherwise I would have noticed.

Not sure if this change is intentional or not, but the only PR I could find that I think could've caused this is #82313, which doesn't seem like it was supposed to significantly change the UI.

@jyn514
Copy link
Member

jyn514 commented Feb 26, 2021 •
edited
Loading

This seems fine to me, or at least not a bug. I think minor css changes are to be expected when we update a css library.

@camelid
Copy link
Member Author

camelid commented Feb 26, 2021

I don't know, it feels a little too far spaced apart to me.

@ghost
Copy link

ghost commented Feb 26, 2021

Looks like not only search results are affected?

https://doc.rust-lang.org/nightly/std/#modules

nightly

https://doc.rust-lang.org/beta/std/#modules

beta

@ghost
Copy link

ghost commented Feb 26, 2021

Oh... #82313 (comment)

TL;DR: Nothing changes except a slight adjustment to line height.

@GuillaumeGomez GuillaumeGomez mentioned this issue Feb 26, 2021
Merged
@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Feb 26, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Feb 26, 2021
@GuillaumeGomez
Rollup merge of rust-lang#82549 - rust-lang:revert-82313-update-norma…
4afd98c 
…lize-css, r=apiraino

Revert "Update normalize.css to 8.0.1"

Reverts rust-lang#82313

Fixes rust-lang#82548
Fixes rust-lang#82542

`@jsha:` I'm reverting until we can come up with a new version which is fully working.

r? `@jyn514`
@bors bors closed this as completed in 0da9b47 Feb 26, 2021
This was referenced Jun 25, 2021
Merged
Closed
@JohnTitor JohnTitor mentioned this issue Jun 29, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Jun 29, 2021
@bors
Auto merge of rust-lang#86725 - JohnTitor:normalizecss-8, r=Guillaume…
6d82086 
…Gomez

Upgrade normalize.css to v8.0.1

Fixes rust-lang#86629, this addresses rust-lang#82548 and rust-lang#82542 with tweaks. I expect that this changes the style *slightly* but shouldn't have any major changes.
Here's some changes I observed, I'd say they all are an improvement.

<details>
<summary>Before</summary>

![before 1](https://user-images.githubusercontent.com/25030997/123854746-0fc84800-d95a-11eb-8484-ea86dfe0ae14.png)
![before 2](https://user-images.githubusercontent.com/25030997/123854754-135bcf00-d95a-11eb-8cca-f49994629e08.png)

</details>

<details>
<summary>After</summary>

![after 1](https://user-images.githubusercontent.com/25030997/123854809-21115480-d95a-11eb-9dd2-0d3b9ca45edd.png)
![after 2](https://user-images.githubusercontent.com/25030997/123854818-22428180-d95a-11eb-83aa-fb5a698124f9.png)

</details>

r? `@jsha`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-search Area: Rustdoc's search feature A-rustdoc-ui Area: rustdoc UI (generated HTML) regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Update normalize.css to 8.0.1" rust-lang/rust
4 participants
@apiraino @jyn514 @camelid @rustbot