Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustfmt no longer builds after rust-lang/rust#83454 #83460

Closed
rust-highfive opened this issue Mar 25, 2021 · 4 comments · Fixed by #84103
Closed

rustfmt no longer builds after rust-lang/rust#83454 #83460

rust-highfive opened this issue Mar 25, 2021 · 4 comments · Fixed by #84103
Assignees
Labels
A-rustfmt Area: Rustfmt C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #83454, I observed that the tool rustfmt no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rustfmt is needed to fix the fallout.

cc @JohnTitor, do you think you would have time to do the follow-up work?
If so, that would be great!

@klensy
Copy link
Contributor

klensy commented Apr 6, 2021

Almost 2 weeks no rustfmt, that prevents default nightly update process via rustup update (without manually selecting components) and generates some number of duplicated issues, as some reporters use default nighly-2021-03-24.

@Berrysoft
Copy link
Contributor

Seems that rustfmt has fixed that. Any progress?

@calebcartwright
Copy link
Member

calebcartwright commented Apr 9, 2021

Folks as always there's a sequence of PRs that have to be made across various repos before the submods can be updated with the fix here. Those PRs have been linked and can be seen above, but will explicitly enumerate them in a comment for reference

At a minimum the steps will include:

Note that the rustc-ap bumps in racer and rustfmt can be done in parallel (step 1's), the other tasks all have to be sequenced

@calebcartwright
Copy link
Member

calebcartwright commented Apr 9, 2021

Seems that rustfmt has fixed that. Any progress?

Want to note that the PR linked to there is not related to the broken toolstate/resolving this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustfmt Area: Rustfmt C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants