Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

64-bit signed/unsigned overflow checked multiplication unavailable on 32-bit #8449

Closed
thestinger opened this issue Aug 11, 2013 · 1 comment · Fixed by #12276
Closed

64-bit signed/unsigned overflow checked multiplication unavailable on 32-bit #8449

thestinger opened this issue Aug 11, 2013 · 1 comment · Fixed by #12276
Labels
A-codegen Area: Code generation

Comments

@thestinger
Copy link
Contributor

LLVM relies on the existence of support in compiler-rt for this on some platforms, but we're using libgcc so it's broken.

http://llvm.org/bugs/show_bug.cgi?id=14469

I suspect we are going to run into this again as we gain support for more of LLVM's capabilities, for now I'm just going to disable CheckedMul for i64 and u64 on 32-bit.
@thestinger thestinger mentioned this issue Aug 11, 2013
Closed
@thestinger thestinger mentioned this issue Sep 20, 2013
Closed
4 tasks
@alexcrichton alexcrichton mentioned this issue Feb 4, 2014
Merged
@alexcrichton
Copy link
Member

This is fixable now that we are linking against compiler-rt

@alexcrichton alexcrichton mentioned this issue Feb 14, 2014
Merged
bors added a commit that referenced this issue Feb 15, 2014
@bors
auto merge of #12276 : alexcrichton/rust/issue-8449, r=kballard
f0bad90 
This was just waiting for compiler-rt support, which was added in #12027

Closes #8449
@durin42 durin42 mentioned this issue Mar 5, 2021
Merged
flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 7, 2022
@bors
Auto merge of rust-lang#8450 - Jarcho:unsafe_blocks_8449, r=giraffate
190f0de 
Rework `undocumented_unsafe_blocks`

fixes: rust-lang#8264
fixes: rust-lang#8449

One thing came up while working on this. Currently comments on the same line are supported like so:

```rust
/* SAFETY: reason */ unsafe {}
```

Is this worth supporting at all? Anything other than a couple of words doesn't really fit well.

edit: [zulip topic](https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/.60undocumented_unsafe_blocks.60.20same.20line.20comment)

changelog: Don't lint `undocumented_unsafe_blocks` when the unsafe block comes from a proc-macro.
changelog: Don't lint `undocumented_unsafe_blocks` when the preceding line has a safety comment and the unsafe block is a sub-expression.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable 64-bit checked multiplication on 32-bit alexcrichton/rust
2 participants
@alexcrichton @thestinger