Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Option<extern "C" fn> in the FFI tutorial #8748

Closed
nikomatsakis opened this issue Aug 25, 2013 · 6 comments · Fixed by #13451
Closed

Document Option<extern "C" fn> in the FFI tutorial #8748

nikomatsakis opened this issue Aug 25, 2013 · 6 comments · Fixed by #13451
Labels
P-medium Medium priority

Comments

@nikomatsakis
Copy link
Contributor

The FFI tutorial should reflect the fact that:

  1. Option<thin-ptr-type> is guaranteed to be a pointer with None represented as NULL.
  2. Option<extern "C" fn> is the recommended way to represent a nullable fn pointer.
@nikomatsakis
Copy link
Contributor Author

Nominating for milestone.

@catamorphism
Copy link
Contributor

Accepted for well-defined

@pnkfelix
Copy link
Member

part of #11755

@brson
Copy link
Contributor

brson commented Apr 8, 2014

Nominating to remove from milestone.

@pnkfelix
Copy link
Member

We can ship 1.0 without this, though it would be good to have this. Leaving as P-high, but removing from 1.0 milestone.

@pnkfelix pnkfelix removed this from the 1.0 milestone Apr 10, 2014
@brson brson removed the I-nominated label Apr 10, 2014
@emberian
Copy link
Member

Taking this.

@emberian emberian self-assigned this Apr 10, 2014
@emberian emberian mentioned this issue Apr 11, 2014
Merged
bors added a commit that referenced this issue Apr 11, 2014
@bors
auto merge of #13451 : cmr/rust/doc-ffi, r=brson
9ff0811 
Closes #8748
flip1995 pushed a commit to flip1995/rust that referenced this issue Jun 4, 2022
@b-ncMN
Fix rust-lang#8748
0a7f19b
flip1995 pushed a commit to flip1995/rust that referenced this issue Jun 4, 2022
@bors
Auto merge of rust-lang#8913 - InfRandomness:ICE-rust-lang#8748, r=gi…
588e198 
…raffate

Fix rust-lang#8748

Thank you for making Clippy better!

changelog: Fix ICE rust-lang#8748 in shadow.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P-medium Medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document the nullable pointer optimization in the FFI guide
5 participants
@brson @nikomatsakis @pnkfelix @catamorphism @emberian