Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: use SVG form of Rust logo by default #92831

Closed
jsha opened this issue Jan 13, 2022 · 0 comments · Fixed by #92854
Closed

rustdoc: use SVG form of Rust logo by default #92831

jsha opened this issue Jan 13, 2022 · 0 comments · Fixed by #92854
Labels
A-rustdoc-ui Area: rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jsha
Copy link
Contributor

jsha commented Jan 13, 2022

Right now rustdoc's default logo is a PNG, which can look fuzzy on large or high DPI screens. Instead, we should use an SVG logo. For instance, there is one available at https://www.rust-lang.org/policies/media-guide. Note that it has somewhat wider margins than the PNG we currently use, so would require some tweaking to have the right size.
@jsha jsha added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: rustdoc UI (generated HTML) labels Jan 13, 2022
@Urgau Urgau mentioned this issue Jan 13, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jan 14, 2022
@matthiaskrgr
Rollup merge of rust-lang#92854 - Urgau:better-rust-logo, r=Guillaume…
ace998e 
…Gomez

Use the updated Rust logo in rustdoc

This pull-request use the updated Rust logo from rust-lang/rust-artwork#9 and also change the logo format from PNG to SVG.

| Before | After |
| --- | --- |
| ![Screenshot 2022-01-13 at 14-33-40 std - Rust](https://user-images.githubusercontent.com/3616612/149342697-7afe4c3e-2be5-444b-86f3-118712b4f7ae.png) | ![Screenshot 2022-01-13 at 14-33-15 std - Rust](https://user-images.githubusercontent.com/3616612/149342705-54ed27c6-0806-4c2d-baa1-4d65ed897e2b.png) |

I also took the liberty to update the two PNG favicons with the SVG reducing their size by ~35% each.

Fixes rust-lang#92831

r? `@jsha`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jan 14, 2022
@matthiaskrgr
Rollup merge of rust-lang#92854 - Urgau:better-rust-logo, r=Guillaume…
93b3c2c 
…Gomez

Use the updated Rust logo in rustdoc

This pull-request use the updated Rust logo from rust-lang/rust-artwork#9 and also change the logo format from PNG to SVG.

| Before | After |
| --- | --- |
| ![Screenshot 2022-01-13 at 14-33-40 std - Rust](https://user-images.githubusercontent.com/3616612/149342697-7afe4c3e-2be5-444b-86f3-118712b4f7ae.png) | ![Screenshot 2022-01-13 at 14-33-15 std - Rust](https://user-images.githubusercontent.com/3616612/149342705-54ed27c6-0806-4c2d-baa1-4d65ed897e2b.png) |

I also took the liberty to update the two PNG favicons with the SVG reducing their size by ~35% each.

Fixes rust-lang#92831

r? ``@jsha``
@bors bors closed this as completed in dae3ef2 Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-ui Area: rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the updated Rust logo in rustdoc Urgau/rust
1 participant
@jsha