Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove allow_fail test flag #93345

Closed
yaahc opened this issue Jan 26, 2022 · 1 comment · Fixed by #93416
Closed

remove allow_fail test flag #93345

yaahc opened this issue Jan 26, 2022 · 1 comment · Fixed by #93416
Assignees
@name1e5s
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@yaahc
Copy link
Member

yaahc commented Jan 26, 2022 •
edited by rustbot
Loading

As noted in #46488 (comment) we've discussed stabilizing this feature and came to the conclusion that we likely need better support for tests that are allowed to fail in certain situations such as when not run in CI, but that we're not confident that this feature is the best way to solve the specific problems people have. For now we would like to remove this feature and follow up later with a more thorough RFC discussion using concrete examples.
@yaahc yaahc added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. E-help-wanted Call for participation: Help is requested to fix this issue. labels Jan 26, 2022
@name1e5s
Copy link
Contributor

@rustbot claim

@name1e5s name1e5s mentioned this issue Jan 28, 2022
Merged
m-ou-se added a commit to m-ou-se/rust that referenced this issue Feb 7, 2022
@m-ou-se
Rollup merge of rust-lang#93416 - name1e5s:chore/remove_allow_fail, r…
6a7a60a 
…=m-ou-se

remove `allow_fail` test flag

close rust-lang#93345
@bors bors closed this as completed in 252ff5e Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@name1e5s name1e5s

Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove allow_fail test flag name1e5s/rust
2 participants
@yaahc @name1e5s