Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude stdarch/crates/{stdarch-verify,intrinsic-test} from rust-src component #94906

Closed
bjorn3 opened this issue Mar 13, 2022 · 0 comments · Fixed by #94907
Closed

Exclude stdarch/crates/{stdarch-verify,intrinsic-test} from rust-src component #94906

bjorn3 opened this issue Mar 13, 2022 · 0 comments · Fixed by #94907
Assignees
@bjorn3

Comments

@bjorn3
Copy link
Member

bjorn3 commented Mar 13, 2022 •
edited

These directories account for 30MB combined of 53MB total for the rust-src component (unpacked size) and are only necessary for testing stdarch, not building. Excluding these directory may need excluding stdarch/Cargo.toml too as they are part of the stdarch workspace.
@bjorn3 bjorn3 self-assigned this Mar 13, 2022
@bjorn3 bjorn3 mentioned this issue Mar 13, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 13, 2022
@matthiaskrgr
Rollup merge of rust-lang#94907 - bjorn3:smaller_rust_src_component, …
c7030d3 
…r=Mark-Simulacrum

Omit stdarch test crates from the rust-src component

These crates aren't necessary for building the standard library. This saves 30MB of disk space.

Fixes rust-lang#94906
@bors bors closed this as completed in cd5e75a Mar 13, 2022
@jonhoo jonhoo mentioned this issue May 20, 2022
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this issue May 22, 2022
@JohnTitor
Rollup merge of rust-lang#97228 - jonhoo:patch-1, r=bjorn3
c7c5980 
Omit stdarch workspace from rust-src

The path `library/stdarch/crates/Cargo.toml` does not exist.

In Rust 1.61.0, `rust-src` still includes `src/rust/library/stdarch/Cargo.toml` (but not `stdarch-verify`), which includes
```toml
[workspace]
members = [
  "crates/stdarch-verify"
```

This didn't show up when testing with `-Zbuild-std` in rust-lang#94907 since the [standard list of crates](https://github.com/rust-lang/cargo/blob/f624095e1c98228a74a165ddb702078c0dd8b81e/src/cargo/core/compiler/standard_lib.rs#L26-L30) to include when building `std` does not include `stdarch`, but it will show up if a user explicitly requests `stdarch`. Or, perhaps more importantly, because of rust-lang#95736, many editors (like IntelliJ) won't treat the root of `rust-src` as a workspace, and will instead recurse into all the sub-crates directly, which then includes `stdarch`.

Also related to rust-lang#94906.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjorn3 bjorn3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Omit stdarch test crates from the rust-src component bjorn3/rust
1 participant
@bjorn3