Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for AtomicBool::fetch_not #98485

Closed
1 of 3 tasks
pluiedev opened this issue Jun 25, 2022 · 7 comments · Fixed by #127204
Closed
1 of 3 tasks

Tracking Issue for AtomicBool::fetch_not #98485

pluiedev opened this issue Jun 25, 2022 · 7 comments · Fixed by #127204
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@pluiedev
Copy link
Contributor

Feature gate: #![feature(atomic_bool_fetch_not)]

This is a tracking issue for the method AtomicBool::fetch_not. This method performs the NOT operation on an AtomicBool,
and returns the old (un-negated) value.

Public API

// in std::sync::atomic

impl AtomicBool {
    pub fn fetch_not(&self, order: Ordering) -> bool;
}

Steps / History

Unresolved Questions

  • None yet.
@pluiedev pluiedev added C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jun 25, 2022
bors bot added a commit to taiki-e/portable-atomic that referenced this issue Jul 31, 2022
24: Provide stable equivalent of #![feature(atomic_bool_fetch_not)] r=taiki-e a=taiki-e

This provides stable equivalent of [`#![feature(atomic_bool_fetch_not)]`](rust-lang/rust#98485).

- `AtomicBool::fetch_not`

Co-authored-by: Taiki Endo <te316e89@gmail.com>
bors bot added a commit to taiki-e/portable-atomic that referenced this issue Jul 31, 2022
24: Provide stable equivalent of #![feature(atomic_bool_fetch_not)] r=taiki-e a=taiki-e

This provides stable equivalent of [`#![feature(atomic_bool_fetch_not)]`](rust-lang/rust#98485).

- `AtomicBool::fetch_not`

Co-authored-by: Taiki Endo <te316e89@gmail.com>
@dimpolo
Copy link
Contributor

dimpolo commented Apr 9, 2024

Should we consider stabilizing this?

@dtolnay
Copy link
Member

dtolnay commented Apr 9, 2024

@rust-lang/libs-api:
@rfcbot fcp merge

atomic.fetch_not(ordering) is equivalent to atomic.fetch_xor(true, ordering).

@rfcbot
Copy link

rfcbot commented Apr 9, 2024

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Apr 9, 2024
@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Apr 30, 2024
@rfcbot
Copy link

rfcbot commented Apr 30, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels May 10, 2024
@rfcbot
Copy link

rfcbot commented May 10, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@apiraino apiraino removed the to-announce Announce this issue on triage meeting label May 16, 2024
@dimpolo
Copy link
Contributor

dimpolo commented Jul 1, 2024

ping :)

@Urgau
Copy link
Member

Urgau commented Jul 1, 2024

@dimpolo Feel free to send a PR stabilizing the feature. Instructions can be found here.

@bors bors closed this as completed in 8a33f7e Jul 3, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jul 3, 2024
Rollup merge of rust-lang#127204 - dimpolo:stabilize_atomic_bool_fetch_not, r=jhpratt

Stabilize atomic_bool_fetch_not

closes rust-lang#98485

`@rustbot` modify labels: +T-libs-api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants