Rollup of 6 pull requests #100304
Merged
Rollup of 6 pull requests #100304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: remove whitespaces from doctest names When rustdoc runs doctests, it removes whitespaces from the tests' path ([code](https://github.com/rust-lang/rust/blob/25bb1c13bd472b75ceebee3b8dcf4dcbc431a8be/src/librustdoc/doctest.rs#L951)). See rust-lang#89422 for details. Interestingly enough, "Run doctest" has been working without much problem even though rust-analyzer hasn't followed the change. This is because cargo passes the test name to rustdoc via `--test-args` option, and then rustdoc [splits it by whitespace](https://github.com/rust-lang/rust/blob/25bb1c13bd472b75ceebee3b8dcf4dcbc431a8be/src/librustdoc/config.rs#L513-L514); the last element of the split test name **always** matches the test name that rustdoc generates. However, it may run other tests unexpectedly (to be precise, this has long since been a thing because of the split). Consider the following example: ```rust struct A<T, U>(T, U); struct B<T, U>(T, U); /// ``` /// doctest here /// ``` impl<T, U> A<T, U> {} /// ``` /// doctest here /// ``` impl<T, U> B<T, U> {} ``` When you "Run doctest" either of the two, rustdoc considers "U>" one of the test specs and both doctests are run. This patch fixes it by following rustdoc and removing the whitespace from the doctests' name.
…schievink feat: Publish extension for 32-bit ARM systems
…evink fix: Fix r-a spelling in some places User-facing change: All commands are now rendered as "rust-analyzer: Command" rather than "Rust Analyzer: Command". Alternative to rust-lang/rust-analyzer#12910 Potentially controversial, since other extensions don't do this, so I won't self-approve.
Add syntax fixup for while loops Part of rust-lang/rust-analyzer#12777 This is a first iteration to gather some feedback. In particular I'm not sure if the curly braces should be added here, but I couldn't get the test to work without them. Any hints welcome!
PathType path parents don't support this assist
…data, r=Veykril feat: support associated values in "Generate Enum Variant" assist This change adds support for associated values to the "Generate Enum Variant" assist. I've split the implementation out into 4 steps to make code review easier: - Add "add_variant" support to the structural ast editing system in `edit_in_place` - Migrate `generate_enum_variant` to use structural ast editing instead of string manipulation - Support tuple fields - Support record fields Please let me know if I should leave the commits as-is, or squash before merging. Fixes rust-lang#12797
minor: Use the release branch in xtask promote
We enforce integral and `Copy` key, so some key-related functions are not necessary since user can just reuse the index for the `entry` call.
Use an empty expander for ignored non-attribute proc-macros Identity is the wrong behaviour for anything that's not an attribute here
due to ordering, added/improved comments and removed redundant test already caught by `E0081.rs`
… fractional part Rather than suggesting to calculate manually
…search, r=wesleywiser Refactor: remove an unnecessary string search
…ylan-DPC Remove more Clean trait implementations Follow-up of rust-lang#99638. r? `@notriddle`
Further improve error message for E0081 Closes rust-lang#97533
…148, r=Mark-Simulacrum Add regression test for rust-lang#79148 closes rust-lang#79148
Update Duration::as_secs doc to point to as_secs_f64/32 for including fractional part Rather than suggesting to calculate manually
…r=lnicola ⬆️ rust-analyzer r? `@ghost`
rustbot
added
T-compiler
|
@bors r+ rollup=never p=7 |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Aug 9, 2022
|
Finished benchmarking commit (5af97e8): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup