Remove Clean trait implementation for hir::Ty and middle::Ty #99638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 23, 2022
…triddle Remove Clean trait implementation for hir::Ty and middle::Ty While going through the code, I realized that the "remove the Clean trait" effort which was started a while ago was never finished. The idea behind it was to make it much simpler to go through the different clean steps (which is definitely not easy when you just have `something.clean(cx)`). I'm planning to finish this effort. cc `@camelid` r? `@notriddle`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 23, 2022
…laumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#99298 (Make `ui-fulldeps/gated-plugins` and `ui-fulldeps/multiple-plugins` tests stage 2 only) - rust-lang#99396 (Add some additional double-adjustment regression tests) - rust-lang#99449 (Do not resolve associated const when there is no provided value) - rust-lang#99595 (Mark atomics as unsupported on thumbv6m) - rust-lang#99627 (Lock stdout once when listing tests) - rust-lang#99638 (Remove Clean trait implementation for hir::Ty and middle::Ty) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
Awesome, thanks Guillaume! ❤️ |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Jul 24, 2022
… r=Dylan-DPC Remove Clean trait implementation for more items Follow up of rust-lang#99638. cc `@camelid` r? `@notriddle`
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 27, 2022
…oval, r=GuillaumeGomez rustdoc: remove Clean trait impls for more items Follow up to rust-lang#99638 and rust-lang#99672
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 27, 2022
…oval, r=GuillaumeGomez rustdoc: remove Clean trait impls for more items Follow up to rust-lang#99638 and rust-lang#99672
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 27, 2022
…oval, r=GuillaumeGomez rustdoc: remove Clean trait impls for more items Follow up to rust-lang#99638 and rust-lang#99672
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 28, 2022
…oval, r=GuillaumeGomez rustdoc: remove Clean trait impls for more items Follow up to rust-lang#99638 and rust-lang#99672
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 28, 2022
…oval, r=GuillaumeGomez rustdoc: remove Clean trait impls for more items Follow up to rust-lang#99638 and rust-lang#99672
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 29, 2022
…notriddle rustdoc: Remove more Clean trait implementations Follow-up of rust-lang#99638. r? `@notriddle`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 30, 2022
…lan-DPC Remove more Clean trait implementations This time it even allowed to remove a function. Follow-up of rust-lang#99638. r? `@notriddle`
This was referenced Aug 1, 2022
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Aug 2, 2022
… r=Dylan-DPC Remove more Clean trait implementations Follow-up of rust-lang#99638. r? `@notriddle`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 2, 2022
…ean, r=notriddle Remove Clean trait for ast::Attribute and improve Attributes::from_ast I prefer to keep this commit on its own for this PR because I'm changing a bit more things than expected originally: I split `Attributes::from_ast` into two because there is only one location making use of its second parameter. Follow-up of rust-lang#99638. r? `@notriddle`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 2, 2022
… r=Dylan-DPC Remove more Clean trait implementations Follow-up of rust-lang#99638. r? ``@notriddle``
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 3, 2022
…ylan-DPC Remove more Clean trait implementations Follow-up of rust-lang#99638. r? `@notriddle`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 3, 2022
…ylan-DPC Remove more Clean trait implementations Follow-up of rust-lang#99638. r? ``@notriddle``
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 4, 2022
…otriddle Remove more Clean trait implementations Follow-up of rust-lang#99638. r? `@notriddle`
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Aug 5, 2022
…ylan-DPC Remove more Clean trait implementations Follow-up of rust-lang#99638. r? `@notriddle`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 6, 2022
…otriddle Remove more Clean trait implementations Follow-up of rust-lang#99638. r? `@notriddle`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 9, 2022
…ylan-DPC Remove more Clean trait implementations Follow-up of rust-lang#99638. r? `@notriddle`
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Aug 9, 2022
…=Dylan-DPC Remove more Clean trait implementations Follow-up of rust-lang#99638. r? `@Dylan-DPC`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 9, 2022
…=notriddle Remove more Clean trait implementations Follow-up of rust-lang#99638. r? `@notriddle`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 9, 2022
…=Dylan-DPC Remove more Clean trait implementations Follow-up of rust-lang#99638. r? ``@Dylan-DPC``
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Aug 11, 2022
…, r=Dylan-DPC Remove more Clean trait implementations Follow-up of rust-lang#99638. r? `@Dylan-DPC`
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Aug 13, 2022
…lan-DPC Remove more Clean trait implementations Follow-up of rust-lang#99638. r? `@Dylan-DPC`
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Aug 13, 2022
…lan-DPC Remove more Clean trait implementations Follow-up of rust-lang#99638. r? ``@Dylan-DPC``
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 14, 2022
… r=Dylan-DPC [rustdoc] remove Clean trait Follow-up of rust-lang#99638. This is (finally!) the last part. r? `@Dylan-DPC`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 14, 2022
… r=Dylan-DPC [rustdoc] remove Clean trait Follow-up of rust-lang#99638. This is (finally!) the last part. r? `@Dylan-DPC`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While going through the code, I realized that the "remove the Clean trait" effort which was started a while ago was never finished.
The idea behind it was to make it much simpler to go through the different clean steps (which is definitely not easy when you just have
something.clean(cx)).I'm planning to finish this effort.
cc @camelid
r? @notriddle