Add warning against unexpected --cfg with --check-cfg

[Urgau]

This PR adds a warning when an unexpected --cfg is specified but not in the specified list of --check-cfg.

This is the follow-up PR I mentioned in #99519.

r? @petrochenkov

[rustbot]

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

[Urgau]

I've update the implementation to use a early lint pass. Let me know if there is something to change.

@rustbot ready

[petrochenkov]

Could you also add a test making sure that crate-level #![allow(unexpected_cfgs)] actually silences the lint?
@rustbot author

[petrochenkov]

@bors r+

[bors]

📌 Commit bc68381 has been approved by petrochenkov

It is now in the queue for this repository.

[matthiaskrgr]

@bors r- looks like some tests failed in a rolluup

---- [ui] src/test/ui/check-cfg/mix.rs stdout ----
diff of stderr:

28	LL | #[cfg_attr(uu, test)]
29	   |            ^^
30	
-	warning: unexpected condition value `bar` for condition name `feature`
-	   |
-	   = help: was set with `--cfg` but isn't in the `--check-cfg` expected values
-	
35	warning: unexpected `unknown_name` as condition name
36	   |
37	   = help: was set with `--cfg` but isn't in the `--check-cfg` expected names

+	
+	warning: unexpected condition value `bar` for condition name `feature`
+	   |
+	   = help: was set with `--cfg` but isn't in the `--check-cfg` expected values
38	
39	warning: unexpected `cfg` condition name
40	  --> $DIR/mix.rs:35:10

#101244

[Urgau]

I re-blessed the test output src/test/ui/check-cfg/mix.rs, should be good to go again.

@rustbot ready

[Urgau]

I've rebased to fix the conflict in compiler/rustc_lint_defs/src/builtin.rs from #94467.

@rustbot ready

[petrochenkov]

@bors r+

[bors]

📌 Commit eccdccf has been approved by petrochenkov

It is now in the queue for this repository.

[bors]

⌛ Testing commit eccdccf with merge be4f3777ade35de16e8a2fdba8acbe40e0ade7b9...

[bors]

💔 Test failed - checks-actions

[rust-log-analyzer]

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] collectionsbenches test:true 66.486
[RUSTC-TIMING] collectionstests test:true 67.485
[RUSTC-TIMING] coretests test:true 93.299
[RUSTC-TIMING] alloc test:true 107.707
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

[Urgau]

== clock drift check ==
local time: Sat Sep 3 00:01:48 UTC 2022
Session terminated, killing shell... ...killed.
time="2022-09-03T00:01:48Z" level=error msg="error waiting for container: unexpected EOF"
network time:
Error: The operation was canceled.

Seems unrelated to the PR. Could be retried.

[matthiaskrgr]

@bors retry

[bors]

⌛ Testing commit eccdccf with merge 47d1cdb...

[bors]

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 47d1cdb to master...

[rust-timer]

Finished benchmarking commit (47d1cdb): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.2%	[2.4%, 4.9%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.7%	[-4.3%, -2.8%]	3
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	4.4%	[4.4%, 4.4%]	1
Regressions ❌ (secondary)	3.6%	[3.6%, 3.6%]	1
Improvements ✅ (primary)	-1.7%	[-1.7%, -1.7%]	1
Improvements ✅ (secondary)	-5.5%	[-6.7%, -4.4%]	3
All ❌✅ (primary)	1.3%	[-1.7%, 4.4%]	2

Footnotes

1. the arithmetic mean of the percent change ↩ ↩²

2. number of relevant changes ↩ ↩²