Convert diagnostics in parser/expr to SessionDiagnostic #100713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-translation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Xiretza
force-pushed
the
parser-expr-session-diagnostics
branch
2 times, most recently
from
1675461
to
7c4b214
Compare
fmease
reviewed
Aug 18, 2022
Xiretza
force-pushed
the
parser-expr-session-diagnostics
branch
2 times, most recently
from
143e9fd
to
6061c7b
Compare
This comment has been minimized.
This comment has been minimized.
Xiretza
force-pushed
the
parser-expr-session-diagnostics
branch
from
6061c7b
to
276f250
Compare
|
|
|
r? rust-lang/diagnostics |
Xiretza
commented
Aug 18, 2022
|
📌 Commit 276f250fe29e879773a27cb1c73eddfdbadbb32b has been approved by It is now in the queue for this repository. |
bors
added
the
S-waiting-on-bors
This comment was marked as resolved.
This comment was marked as resolved.
bors
added
S-waiting-on-author
Xiretza
force-pushed
the
parser-expr-session-diagnostics
branch
from
276f250
to
5cb75b9
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Xiretza
force-pushed
the
parser-expr-session-diagnostics
branch
from
5cb75b9
to
ffcaa0d
Compare
|
@bors r=estebank |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Aug 22, 2022
…stics, r=estebank Convert diagnostics in parser/expr to SessionDiagnostic This migrates all the easy cases in `rustc_parse::parser::expr` to `SessionDiagnostic`s, I've left things such as `multipart_suggestion`s out for now in the hopes of a derive API being developed soon.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 22, 2022
Rollup of 8 pull requests Successful merges: - rust-lang#98200 (Expand potential inner `Or` pattern for THIR) - rust-lang#99770 (Make some const prop mir-opt tests `unit-test`s) - rust-lang#99957 (Rework Ipv6Addr::is_global to check for global reachability rather than global scope - rebase) - rust-lang#100331 (Guarantee `try_reserve` preserves the contents on error) - rust-lang#100336 (Fix two const_trait_impl issues) - rust-lang#100713 (Convert diagnostics in parser/expr to SessionDiagnostic) - rust-lang#100820 (Use pointer `is_aligned*` methods) - rust-lang#100872 (Add guarantee that Vec::default() does not alloc) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates all the easy cases in
rustc_parse::parser::exprtoSessionDiagnostics, I've left things such asmultipart_suggestions out for now in the hopes of a derive API being developed soon.