Make pointer related code in std and compiler nicer
#100746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...replacing `.cast().wrapping_offset().cast()` & similar code.
rustbot
added
the
T-compiler
rustbot
added
the
T-libs
This comment was marked as resolved.
This comment was marked as resolved.
rust-highfive
added
the
S-waiting-on-review
WaffleLapkin
force-pushed
the
niiice_ptr
branch
from
796e0a0
to
91969cf
Compare
This comment has been minimized.
This comment has been minimized.
WaffleLapkin
force-pushed
the
niiice_ptr
branch
from
91969cf
to
e055e60
Compare
|
☔ The latest upstream changes (presumably #100793) made this pull request unmergeable. Please resolve the merge conflicts. |
You probably did, but this is a very long scroll bar. Would you mind sending it as a couple of different PRs instead? (Especially since there's some conflicts now too, which is particularly likely with a big PR.) For example, a PR that's just "hey, I replaced offset with add/sub in the way that's obviously correct" is something that I could easily scan and agree "yup, definitely" and sign-off on it quickly. But once there's more complicated changes, like types of local variables, I feel like I should be thinking about it more before signing off. For example, in - let d1 = ((n % 100) as isize) << 1;
+ let d1 = ((n % 100) << 1) as usize;you probably got it correct, but now that shift is possibly working in a different type, so it's not "obviously correct" -- it needs contextual analysis to be sure. So separating those out into the lots-of-the-same-easy-change review and the fewer-more-careful-changes review would be a big help. @rustbot author |
rustbot
added
S-waiting-on-author
|
Sure, I'll split this up |
This was referenced Aug 20, 2022
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Sep 24, 2022
Refactor some `std` code that works with pointer offstes This PR replaces `pointer::offset` in standard library with `pointer::add` and `pointer::sub`, [re]moving some casts and using `.addr()` while we are at it. This is a more complicated refactor than all other sibling PRs, so take a closer look when reviewing, please 😃 (though I've checked this multiple times and it looks fine). r? ``@scottmcm`` _split off from rust-lang#100746, continuation of #100822_
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Sep 24, 2022
Refactor some `std` code that works with pointer offstes This PR replaces `pointer::offset` in standard library with `pointer::add` and `pointer::sub`, [re]moving some casts and using `.addr()` while we are at it. This is a more complicated refactor than all other sibling PRs, so take a closer look when reviewing, please 😃 (though I've checked this multiple times and it looks fine). r? ```@scottmcm``` _split off from rust-lang#100746, continuation of #100822_
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 24, 2022
Refactor some `std` code that works with pointer offstes This PR replaces `pointer::offset` in standard library with `pointer::add` and `pointer::sub`, [re]moving some casts and using `.addr()` while we are at it. This is a more complicated refactor than all other sibling PRs, so take a closer look when reviewing, please 😃 (though I've checked this multiple times and it looks fine). r? ````@scottmcm```` _split off from rust-lang#100746, continuation of #100822_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes code that works with pointer a little nicer. Namely it
wrapping_byte_add,wrapping_byte_subandbyte_add(replacing explicit casts)is_alignedandis_aligned_to(replacing hand-written alignment checks)pointer::offsetwithaddandsub(generally making code cleaner)r? @scottmcm