Rollup of 8 pull requests #101026

Dylan-DPC · 2022-08-26T06:53:58Z

Successful merges:

Add IsTerminal trait to determine if a descriptor or handle is a terminal #98033 (Add IsTerminal trait to determine if a descriptor or handle is a terminal)
Add a File::create_new constructor #98801 (Add a File::create_new constructor)
Add comments about stdout locking #99742 (Add comments about stdout locking)
interpret: remove support for uninitialized scalars #100043 (interpret: remove support for uninitialized scalars)
Improve const mismatch FulfillmentError #100437 (Improve const mismatch FulfillmentError)
Migrate ast lowering to session diagnostic #100724 (Migrate ast lowering to session diagnostic)
extra sanity check against consts pointing to mutable memory #100897 (extra sanity check against consts pointing to mutable memory)
rustdoc: remove unused CSS for .variants_table #101012 (rustdoc: remove unused CSS for .variants_table)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

We have `File::create` for creating a file or opening an existing file, but the secure way to guarantee creating a new file requires a longhand invocation via `OpenOptions`. Add `File::create_new` to handle this case, to make it easier for people to do secure file creation.

…nitialized Scalar

…rminal The UNIX and WASI implementations use `isatty`. The Windows implementation uses the same logic the `atty` crate uses, including the hack needed to detect msys terminals. Implement this trait for `File` and for `Stdin`/`Stdout`/`Stderr` and their locked counterparts on all platforms. On UNIX and WASI, implement it for `BorrowedFd`/`OwnedFd`. On Windows, implement it for `BorrowedHandle`/`OwnedHandle`. Based on rust-lang#91121 Co-authored-by: Matt Wilkinson <mattwilki17@gmail.com>

If a process has no console, it'll have NULL in place of a console handle, so return early with `false` in that case without making any OS calls.

Rather than referencing a slice's pointer and then creating a new slice with a longer length, offset from the base structure pointer instead. This makes some choices of Rust semantics happier.

Continuation of rust-lang#100938 and rust-lang#101010. This rule was added to support the old, table-based style for displaying enum variants, which are now displayed using headers and paragraphs.

… r=thomcc Add `IsTerminal` trait to determine if a descriptor or handle is a terminal The UNIX implementation uses `isatty`. The Windows implementation uses the same logic the `atty` crate uses, including the hack needed to detect msys terminals. Implement this trait for `Stdin`/`Stdout`/`Stderr`/`File` on all platforms. On Unix, implement it for `BorrowedFd`/`OwnedFd`. On Windows, implement it for `BorrowedHandle`/`OwnedHandle`. Based on rust-lang#91121 Co-authored-by: Matt Wilkinson <mattwilki17@gmail.com>

Add a `File::create_new` constructor We have `File::create` for creating a file or opening an existing file, but the secure way to guarantee creating a new file requires a longhand invocation via `OpenOptions`. Add `File::create_new` to handle this case, to make it easier for people to do secure file creation.

Add comments about stdout locking This is the source of some confusion regarding the `println!` macro: * https://llogiq.github.io/2017/06/01/perf-pitfalls.html#unbuffered-io * https://news.ycombinator.com/item?id=18794930 * https://reddit.com/r/rust/comments/5puyx2/why_is_println_so_slow/dcua5g5/ * https://reddit.com/r/rust/comments/ab7hsi/comparing_pythagorean_triples_in_c_d_and_rust/ecy7ql8/ In some of these cases it's not the locking behavior where the bottleneck lies, but it's still mentioned as a surprise when, eg, benchmarking a million `println!`'s in a very tight loop. If there's any stylistic problems please feel free to correct me! This is my first contribution and I want to get it right 🦀

…-obk interpret: remove support for uninitialized scalars With Miri no longer supporting `-Zmiri-allow-uninit-numbers`, we no longer need to support storing uninit data in a `Scalar`. We anyway already only use this representation for types with *initialized* `Scalar` layout (and we have to, due to partial initialization), so let's get rid of the `ScalarMaybeUninit` type entirely. I tried to stage this into meaningful commits, but the one that changes `read_immediate` to always trigger UB on uninit is the largest chunk of the PR and I don't see how it could be subdivided. Fixes rust-lang/miri#2187 r? ``@oli-obk``

…tch-err, r=oli-obk Improve const mismatch `FulfillmentError` Fixes rust-lang#100414

…-session-diagnostic, r=davidtwco Migrate ast lowering to session diagnostic I migrated the whole rustc_ast_lowering crate to session diagnostic *except* the for the use of `span_fatal` at /compiler/rustc_ast_lowering/src/expr.rs#L1268 because `#[fatal(...)]` is not yet supported (see rust-lang#100694).

extra sanity check against consts pointing to mutable memory This should be both unreachable and redundant (since we already ensure that validation only reads from read-only memory, when validating consts), but I feel like we cannot be paranoid enough here, and also if this ever fails it'll be a nicer error than the "cannot read from mutable memory" error.

…, r=jsha rustdoc: remove unused CSS for `.variants_table` Continuation of rust-lang#100938 and rust-lang#101010. This rule was added to support the old, table-based style for displaying enum variants, which are now displayed using headers and paragraphs.

Dylan-DPC · 2022-08-26T06:54:10Z

@bors r+ rollup=never p=5

bors · 2022-08-26T06:54:12Z

📌 Commit b125b05 has been approved by Dylan-DPC

It is now in the queue for this repository.

bors · 2022-08-26T09:09:08Z

⌛ Testing commit b125b05 with merge 651751aaa41575da536a0e3f4fa9ed062e3f1a84...

bors · 2022-08-26T09:26:53Z

💔 Test failed - checks-actions

rust-log-analyzer · 2022-08-26T09:27:34Z

The job test-various failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] gimli test:false 4.276
[RUSTC-TIMING] object test:false 4.538
warning: dropping unsupported crate type `dylib` for target `wasm32-unknown-unknown`

error: unused variable: `x`
  --> library/std/src/sys/wasm/../unsupported/io.rs:49:23
   |
49 | pub fn is_terminal<T>(x: &T) -> bool {
   |                       ^ help: if this is intentional, prefix it with an underscore: `_x`
   |
   = note: `-D unused-variables` implied by `-D warnings`
[RUSTC-TIMING] std test:false 2.778
warning: `std` (lib) generated 1 warning
error: could not compile `std` due to previous error; 1 warning emitted
Build completed unsuccessfully in 0:11:53

joshtriplett · 2022-08-26T13:42:49Z

Fixed the warning.

EDIT: sorry, wrong issue, meant to post this to the original issue.)

bors · 2022-08-26T13:42:51Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
There's another pull request that is currently being tested, blocking this pull request: Rollup of 8 pull requests #101037

bors · 2022-08-26T13:42:52Z

📌 Commit b125b05 has been approved by thomcc

It is now in the queue for this repository.

joshtriplett · 2022-08-26T13:43:31Z

@bors r-

joshtriplett and others added 30 commits July 12, 2022 21:30

Add comments about stdout locking

fab36d1

fix an outdated machine hook name

bafb10d

remove enforce_number_init machine hook that Miri no longer needs

d34df43

remove some now-unnecessary parameters from check_bytes

c542245

make read_immediate error immediately on uninit, so ImmTy can carry i…

8654522

…nitialized Scalar

remove now-unused ScalarMaybeUninit

c11fa89

Migrate ast_lowering::path to SessionDiagnostic

73ae38b

Migrate ast_lowering::lib and ast_lowering::item to SessionDiagnostic

0043d10

Migrate ast_lowering::expr to SessionDiagnostic

1382d30

Migrate ast_lowering::ast to SessionDiagnostic

d75fd91

Migrate ast_lowering::pat to SessionDiagnostic

5164966

Migrate all span_err(...) in ast_lowering to SessionDiagnostic

e701c72

Changes made in response to feedback

9472df1

Resolve conflicts

5fef1b8

extra sanity check against consts pointing to mutable memory

cb4cd73

Call them constants instead of types

4e97626

Note binding obligation causes for const equate errors

4ff5872

Add test for rust-lang#100414

d464d3a

Use ExprItemObligation and ExprBindingObligation too

8189a45

Make is_terminal fail fast if a process has no console at all

a7e5dc2

If a process has no console, it'll have NULL in place of a console handle, so return early with `false` in that case without making any OS calls.

Rewrite FILE_NAME_INFO handling to avoid enlarging slice reference

6c5c32b

Rather than referencing a slice's pointer and then creating a new slice with a longer length, offset from the base structure pointer instead. This makes some choices of Rust semantics happier.

rustdoc: remove unused CSS for .variants_table

8c65478

Continuation of rust-lang#100938 and rust-lang#101010. This rule was added to support the old, table-based style for displaying enum variants, which are now displayed using headers and paragraphs.

Rollup merge of rust-lang#100437 - compiler-errors:better-const-misma…

57d438f

…tch-err, r=oli-obk Improve const mismatch `FulfillmentError` Fixes rust-lang#100414

Dylan-DPC added 2 commits August 26, 2022 12:23

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 26, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 26, 2022

Dylan-DPC mentioned this pull request Aug 26, 2022

Add IsTerminal trait to determine if a descriptor or handle is a terminal #98033

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2022

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 26, 2022

Dylan-DPC closed this Aug 26, 2022

Dylan-DPC deleted the rollup-ubs8h7l branch August 26, 2022 13:47

davidtwco removed the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Oct 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 8 pull requests #101026

Rollup of 8 pull requests #101026

Dylan-DPC commented Aug 26, 2022

Dylan-DPC commented Aug 26, 2022

bors commented Aug 26, 2022

bors commented Aug 26, 2022

bors commented Aug 26, 2022

rust-log-analyzer commented Aug 26, 2022

joshtriplett commented Aug 26, 2022 •

edited

Loading

bors commented Aug 26, 2022

bors commented Aug 26, 2022

joshtriplett commented Aug 26, 2022

Rollup of 8 pull requests #101026

Rollup of 8 pull requests #101026

Conversation

Dylan-DPC commented Aug 26, 2022

Dylan-DPC commented Aug 26, 2022

bors commented Aug 26, 2022

bors commented Aug 26, 2022

bors commented Aug 26, 2022

rust-log-analyzer commented Aug 26, 2022

joshtriplett commented Aug 26, 2022 • edited Loading

bors commented Aug 26, 2022

bors commented Aug 26, 2022

joshtriplett commented Aug 26, 2022

joshtriplett commented Aug 26, 2022 •

edited

Loading