Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate ast lowering to session diagnostic #100724

Merged
merged 8 commits into from
Aug 27, 2022
Merged

Migrate ast lowering to session diagnostic #100724

merged 8 commits into from
Aug 27, 2022

Conversation

JeanCASPAR
Copy link
Contributor

I migrated the whole rustc_ast_lowering crate to session diagnostic except the for the use of span_fatal at /compiler/rustc_ast_lowering/src/expr.rs#L1268 because #[fatal(...)] is not yet supported (see #100694).

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 18, 2022
@rustbot
Copy link
Collaborator

rustbot commented Aug 18, 2022

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 18, 2022
@davidtwco
Copy link
Member

r? @davidtwco

davidtwco
davidtwco requested changes Aug 19, 2022
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great, thanks for working on it. I've left a few comments.

compiler/rustc_ast_lowering/src/lib.rs Outdated Show resolved Hide resolved
compiler/rustc_ast_lowering/src/lib.rs Show resolved Hide resolved
compiler/rustc_ast_lowering/src/errors.rs Outdated Show resolved Hide resolved
compiler/rustc_ast_lowering/src/errors.rs Outdated Show resolved Hide resolved
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 19, 2022

📌 Commit e34da16 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2022
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Aug 20, 2022
@ChrisDenton
Rollup merge of rust-lang#100724 - JeanCASPAR:migrate-ast_lowering-to…
b7e9b99 
…-session-diagnostic, r=davidtwco

Migrate ast lowering to session diagnostic

I migrated the whole rustc_ast_lowering crate to session diagnostic *except* the for the use of `span_fatal` at /compiler/rustc_ast_lowering/src/expr.rs#L1268 because `#[fatal(...)]` is not yet supported (see rust-lang#100694).
@ChrisDenton ChrisDenton mentioned this pull request Aug 20, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Aug 20, 2022
@Dylan-DPC
Rollup merge of rust-lang#100724 - JeanCASPAR:migrate-ast_lowering-to…
de9878a 
…-session-diagnostic, r=davidtwco

Migrate ast lowering to session diagnostic

I migrated the whole rustc_ast_lowering crate to session diagnostic *except* the for the use of `span_fatal` at /compiler/rustc_ast_lowering/src/expr.rs#L1268 because `#[fatal(...)]` is not yet supported (see rust-lang#100694).
@Dylan-DPC Dylan-DPC mentioned this pull request Aug 20, 2022
Closed
@bors

This comment was marked as resolved.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 22, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

This comment was marked as resolved.

Sign in to view
@JeanCASPAR JeanCASPAR force-pushed the migrate-ast_lowering-to-session-diagnostic branch from b4a8f2f to 1a4ee21 Compare August 22, 2022 12:32
@davidtwco
Copy link
Member

Could you remove the merge commits? We have a no merge policy - thanks!

@davidtwco
Copy link
Member

r=me after merge commits removed

@JeanCASPAR JeanCASPAR force-pushed the migrate-ast_lowering-to-session-diagnostic branch from 9736e72 to 5fef1b8 Compare August 22, 2022 19:58
@JeanCASPAR
Copy link
Contributor Author

@bors r=davidtwco

@bors
Copy link
Contributor

bors commented Aug 22, 2022

@JeanCASPAR: 🔑 Insufficient privileges: Not in reviewers

@JeanCASPAR
Copy link
Contributor Author

Don't know if this intended, @davidtwco ?

@davidtwco
Copy link
Member

Don't know if this intended, @davidtwco ?

It is, only approved reviewers can r+, I just left that comment in case another reviewer looked at the PR and saw that they could approve on my behalf after you resolved the comment.

@bors r+

@bors
Copy link
Contributor

bors commented Aug 23, 2022

📌 Commit 5fef1b8 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 23, 2022
@davidtwco davidtwco mentioned this pull request Aug 23, 2022
Open
84 tasks
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Aug 26, 2022
@Dylan-DPC
Rollup merge of rust-lang#100724 - JeanCASPAR:migrate-ast_lowering-to…
ef95092 
…-session-diagnostic, r=davidtwco

Migrate ast lowering to session diagnostic

I migrated the whole rustc_ast_lowering crate to session diagnostic *except* the for the use of `span_fatal` at /compiler/rustc_ast_lowering/src/expr.rs#L1268 because `#[fatal(...)]` is not yet supported (see rust-lang#100694).
@Dylan-DPC Dylan-DPC mentioned this pull request Aug 26, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Aug 26, 2022
@Dylan-DPC
Rollup merge of rust-lang#100724 - JeanCASPAR:migrate-ast_lowering-to…
acad0ee 
…-session-diagnostic, r=davidtwco

Migrate ast lowering to session diagnostic

I migrated the whole rustc_ast_lowering crate to session diagnostic *except* the for the use of `span_fatal` at /compiler/rustc_ast_lowering/src/expr.rs#L1268 because `#[fatal(...)]` is not yet supported (see rust-lang#100694).
@Dylan-DPC Dylan-DPC mentioned this pull request Aug 26, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Aug 26, 2022
@Dylan-DPC
Rollup merge of rust-lang#100724 - JeanCASPAR:migrate-ast_lowering-to…
8a56eb6 
…-session-diagnostic, r=davidtwco

Migrate ast lowering to session diagnostic

I migrated the whole rustc_ast_lowering crate to session diagnostic *except* the for the use of `span_fatal` at /compiler/rustc_ast_lowering/src/expr.rs#L1268 because `#[fatal(...)]` is not yet supported (see rust-lang#100694).
@Dylan-DPC Dylan-DPC mentioned this pull request Aug 26, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Aug 26, 2022
@Dylan-DPC
Rollup merge of rust-lang#100724 - JeanCASPAR:migrate-ast_lowering-to…
a0b8f22 
…-session-diagnostic, r=davidtwco

Migrate ast lowering to session diagnostic

I migrated the whole rustc_ast_lowering crate to session diagnostic *except* the for the use of `span_fatal` at /compiler/rustc_ast_lowering/src/expr.rs#L1268 because `#[fatal(...)]` is not yet supported (see rust-lang#100694).
@Dylan-DPC Dylan-DPC mentioned this pull request Aug 26, 2022
Closed
@compiler-errors
Copy link
Member

@bors rollup

@compiler-errors compiler-errors mentioned this pull request Aug 26, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 27, 2022
@bors
Auto merge of rust-lang#101064 - compiler-errors:rollup-fwm5m5f, r=co…
bb8a08f 
…mpiler-errors

Rollup of 9 pull requests

Successful merges:

 - rust-lang#100724 (Migrate ast lowering to session diagnostic)
 - rust-lang#100735 (Migrate `rustc_ty_utils` to `SessionDiagnostic`)
 - rust-lang#100738 (Diagnostics migr const eval)
 - rust-lang#100744 (Migrate rustc_mir_dataflow to diagnostic structs)
 - rust-lang#100776 (Migrate `rustc_lint` errors to `SessionDiagnostic`)
 - rust-lang#100817 (sugg: suggest the usage of boolean value when there is a typo in the keyword)
 - rust-lang#100836 (Migrate `rustc_attr` crate diagnostics)
 - rust-lang#100890 (Migrate rustc_driver to SessionDiagnostic)
 - rust-lang#100900 (on `region_errors.rs`)

Failed merges:

 - rust-lang#100831 (Migrate `symbol_mangling` module to new diagnostics structs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bc1d205 into rust-lang:master Aug 27, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@JeanCASPAR @rust-highfive @rustbot @davidtwco @bors @rust-log-analyzer @compiler-errors @petrochenkov