Rollup of 10 pull requests #101220
Merged
Rollup of 10 pull requests #101220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This workaround avoids constant crashing of rust analyzer when using GATs with const generics, even when the const generics are only on the `impl` block. The workaround treats GATs as non-existing if either itself or the parent has const generics and removes relevant panicking code-paths.
weren't used in the end
internal: remove unnecessary stream writer try_clone in lsp-server
…ng, r=Veykril feat: make trait assoc items become inactive due to cfg fixes rust-lang#12394
Replace crossbeam with std's scoped threads Probably best to wait a week or two so we don't immediately give linux packagers problems again
fix: Fix panics on GATs involving const generics This workaround avoids constant crashing of rust analyzer when using GATs with const generics, even when the const generics are only on the `impl` block. The workaround treats GATs as non-existing if either itself or the parent has const generics and removes relevant panicking code-paths. Fixes rust-lang#11989, fixes rust-lang#12193
Pop an error notification when flycheck can't be restarted
This mirrors the implementations on Unix platforms, and also mirrors the existing `AsRawFd` impls.
feat: emit SCIP from rust-analyzer hi rust-analyzer team I'm one of the engineers at Sourcegraph (and have done a few small changes related to the LSIF work done in rust-analyzer). Recently, we've moved to a new protocol as the primary way to interact with Sourcegraph (LSIF is still possible to upload, so existing jobs will not stop working any time soon). This new protocol is SCIP (I linked a blog post below with more information). I've implemented SCIP support (based largely on the existing LSIF support). In addition to supporting the existing features that `rust-analyzer`'s LSIF support does, this PR adds the ability to move between crates on sourcegraph.com. So if both your project and a dependency are indexed, you would be able to hop to the particular version and view the source code. I'd be happy to record a demo of that on my local instance if you're interested. There are a few TODO's left in the code (some that you might have insights on) which I'm happy to fix in this PR, but I just wanted to open this up for discussion first. Thanks for your time :) TJ - [announcing scip](https://about.sourcegraph.com/blog/announcing-scip)
Do not substitute `Self` when in same impl block Fix rust-lang#13076
Co-authored-by: Tyler Mandry <tmandry@gmail.com>
Co-authored-by: Tyler Mandry <tmandry@gmail.com>
…r-ayu, r=notriddle Fix search results color on hover for ayu theme Before:  After:  You can test it [here](https://rustdoc.crud.net/imperio/search-results-color-ayu/foo/index.html?search=item). r? ``@jsha``
…htriplett Add `AsFd` implementations for stdio types on WASI. This mirrors the implementations on Unix platforms, and also mirrors the existing `AsRawFd` impls.
… r=tmandry Adding new Fuchsia rustup docs... reworking walkthrough Docs improvements: * Adding new `rustup` target add for Fuchsia targets * Reworking walkthrough to show directory building as it happens * Reworking walkthrough to use `hello_fuchsia_pkg/` directory cc. `@djkoloski`
…davidtwco Set DebuginfoKind::Pdb in msvc_base This PDB setting was added to `windows_msvc_base` in rust-lang#98051. It's also needed for the UEFI targets, and since `uefi_msvc_base` and `windows_msvc_base` are the only things that inherit from `msvc_base`, just move the PDB setting up to `mscv_base` to cover both. Fixes rust-lang#101071
…t, r=Mark-Simulacrum add tracking issue number to const_slice_split_at_not_mut Add issue number rust-lang#101158 to `const_slice_split_at_not_mut` feature.
…iler-errors Remove path string
…nton Avoid zeroing large stack buffers in stdio on Windows Does what it says on the tin, using `[MaybeUninit<u16>; N]` instead of `[0u16; N]`. These buffers seem to be around 8kb, which is big enough that this is likely to be a very nice perf boost to stdio-heavy windows code. r? ``@ChrisDenton`` *(Note: this PR also has a commit that adds windows to CI, but as it mentions I'll revert that after it comes out green -- I can only do a check build on the machine I'm typing this on)*
…r=lnicola ⬆️ rust-analyzer r? ``@ghost``
Add test for issue rust-lang#85872 This has been fixed by the LLVM 15 upgrade, add a codegen test. Fixes rust-lang#85872.
Update books ## nomicon 1 commits in 8e6aa3448515a0654e347b5e2510f1d4bc4d5a64..d880e6ac2acf133dce640da24b9fb692844f02d4 2022-08-15 15:36:13 -0700 to 2022-08-24 12:42:34 -0700 - Update lifetimes.md (rust-lang/nomicon#372) ## reference 2 commits in e647eb102890e8927f488bea12672b079eff8d9d..f62e93c28323ed9637d0a205a0c256498674a509 2022-08-16 11:35:27 -0700 to 2022-08-28 10:01:28 -0700 - Update examples of what implements `Termination` (rust-lang/reference#1256) - allow to quickly edit a page directly on github (rust-lang/reference#1254) ## book 7 commits in 42ca0ef484fcc8437a0682cee23abe4b7c407d52..0a5421ceb238357b3634fb75234eba4d1dad643c 2022-08-12 21:52:02 -0400 to 2022-08-28 19:51:04 -0400 - Add a missing line generated by 'cargo new' - Clarify ThreadPool-Worker analogy wording - Fixed incorrect mutex lock usage - Merge remote-tracking branch 'origin/pr/3314' - Put interactive book notice in a blockquote box to draw attention to it - Remove the word 'new' because someday it won't be new anymore - Merge remote-tracking branch 'origin/pr/3304' ## rustc-dev-guide 27 commits in d3daa1f28e169087becbc5e2b49ac91ca0405a44..04892c1a6fc145602ac7367945fda9d4ee83c9fb 2022-08-13 10:00:38 +0900 to 2022-08-29 20:07:51 +0200 - Fix the link to `Parser` struct - Remove a dangling link on "The `#[test]` attribute" - Update the stabilization guide to refer to the new placeholder system - Refine the lintstore section (rust-lang/rustc-dev-guide#1429) - typo - Updates text to refer to LLVM documentation. - Updates LLVM prereqs since upgrade to C++17. - we got 3 (rust-lang/rustc-dev-guide#1447) - A few corrections - Update some statements - correct typo in parallel-rustc.md - Correct some statements in parallel-rustc.md - update parallel-rustc.md - address review comment - make date-check more easy to use - update thir output (rust-lang/rustc-dev-guide#1445) - do not offer option to run code (rust-lang/rustc-dev-guide#1442) - fix quick-edit link (rust-lang/rustc-dev-guide#1441) - Document changes introduced by kind-less SessionDiagnostics - diagnostics: fix outdated use of string slugs (rust-lang/rustc-dev-guide#1436) - Add missing lifetime (rust-lang/rustc-dev-guide#1439) - more syntax fixes - fix incorrect #[note] syntax - Update slug style to use _ instead of - (rust-lang/rustc-dev-guide#1426) - remove incorrect info (rust-lang/rustc-dev-guide#1435) - fix lifetime name (rust-lang/rustc-dev-guide#1431) - Update the date reference around Git submodule bug (rust-lang/rustc-dev-guide#1430)
rustbot
added
T-compiler
|
@bors r+ rollup=never p=10 |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: f07d6e8c0a In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (7f442f8): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
AsFdimplementations for stdio types on WASI. #100892 (AddAsFdimplementations for stdio types on WASI.).reverse()with more than one usage in the same file #85872)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup