Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for legacy PM #101997

Merged
merged 6 commits into from
Sep 25, 2022
Merged

Remove support for legacy PM #101997

merged 6 commits into from
Sep 25, 2022

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Sep 18, 2022

This removes support for optimizing with LLVM's legacy pass manager, as well as the unstable -Znew-llvm-pass-manager option. We have been defaulting to the new PM since LLVM 13 (except for s390x that waited for 14), and LLVM 15 removed support altogether. The only place we still use the legacy PM is for writing the output file, just like llc does.

cc #74705
r? @nikic

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 18, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 18, 2022
Co-authored-by: Andreas Jonson <andjo403@users.noreply.github.com>
@nikic
Copy link
Contributor

nikic commented Sep 19, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Sep 19, 2022

📌 Commit 00bb9fc has been approved by nikic

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 25, 2022
…fee1-dead

Rollup of 8 pull requests

Successful merges:

 - rust-lang#98111 (Clarify `[T]::select_nth_unstable*` return values)
 - rust-lang#101431 (Look at move place's type when suggesting mutable reborrow)
 - rust-lang#101800 (Constify slice.split_at_mut(_unchecked))
 - rust-lang#101997 (Remove support for legacy PM)
 - rust-lang#102194 (Note the type when unable to drop values in compile time)
 - rust-lang#102200 (Constify Default impl's for Arrays and Tuples.)
 - rust-lang#102245 (Constify cmp_min_max_by.)
 - rust-lang#102259 (Type-annotate and simplify documentation of Option::unwrap_or_default)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 07467c5 into rust-lang:master Sep 25, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 25, 2022
@cuviper cuviper deleted the drop-legacy-pm branch October 15, 2022 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants