Rollup of 8 pull requests #102050
Closed
Rollup of 8 pull requests #102050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class was originally added in 73b97c7 to support hiding and showing the item, because `main.js` went through all `docblock` elements in the DOM and added toggles to them. https://github.com/rust-lang/rust/blob/73b97c7e7c9cfac4dfa4804654b1db6ab687b589/src/librustdoc/html/static/main.js#L1856-L1867 The `item-decl` is no longer auto-hidden since c96f86d removed it. `item-decl` used to be called `type-decl`: that name was changed in 8b7a2dd. The `docblock` class is no longer used for implementing toggles, since rustdoc switched to using `<details>` elements.
Since rust-lang#88679, rustdoc doesn't load crates eagerly. Add an explicit `extern crate` item to make sure the crate is loaded and the bug reproduces. You can verify this fix by adding `// compile-flags: -Znormalizing-docs` and running the test.
…e, r=oli-obk Improve error for when query is unsupported by crate This is an improvement to the error message mentioned on rust-lang#101666. It seems like a good idea to also add [this link to the rustc-dev-guide](https://rustc-dev-guide.rust-lang.org/query.html), if explaining the query system in detail is a concern here, but I'm unsure if there is any restrictions on adding links to error messages.
…i-obk MirPhase: clarify that linting is not a semantic change r? `@JakobDegen`
Use LLVM C-API to build atomic cmpxchg and fence We don't need C++ wrappers because the LLVM C API can build these.
…est, r=notriddle Add GUI test for notable traits element position Fixes rust-lang#101891. r? ``@notriddle``
…=compiler-errors Simplify rpitit handling on lower_fn_decl r? ```@compiler-errors```
some post-valtree cleanup r? project-const-generics cc `@b-naber`
…decl, r=GuillaumeGomez rustdoc: remove `docblock` class from `item-decl` This class was originally added in 73b97c7 to support hiding and showing the item, because `main.js` went through all `docblock` elements in the DOM and added toggles to them. https://github.com/rust-lang/rust/blob/73b97c7e7c9cfac4dfa4804654b1db6ab687b589/src/librustdoc/html/static/main.js#L1856-L1867 The `item-decl` is no longer auto-hidden since c96f86d removed it. `item-decl` used to be called `type-decl`: that name was changed in 8b7a2dd. The `docblock` class is no longer used for implementing toggles, since rustdoc switched to using `<details>` elements. Preview: https://notriddle.com/notriddle-rustdoc-test/docblock-item-decl/rustdoc/clean/types/enum.Type.html
…ompiler-errors Make the `normalize-overflow` rustdoc test actually do something Since rust-lang#88679, rustdoc doesn't load crates eagerly. Add an explicit `extern crate` item to make sure the crate is loaded and the bug reproduces. You can verify this fix by adding `// compile-flags: -Znormalize-docs` and running the test to make sure it gives an error.
rustbot
added
T-compiler
|
@bors r+ rollup=never p=8 |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit a8414e6 with merge e133d84ea78cf9b9b3d626af4764a7b284450252... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry github 404 |
bors
added
S-waiting-on-bors
|
⌛ Testing commit a8414e6 with merge 190689c45f507ad0b6156ded2c16b8a5dc4b1913... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry github 404 |
bors
added
S-waiting-on-bors
|
Superseeded by #102061 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
docblockclass fromitem-decl#102027 (rustdoc: removedocblockclass fromitem-decl)normalize-overflowrustdoc test actually do something #102038 (Make thenormalize-overflowrustdoc test actually do something)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup