Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ptr::Alignment type #102072

Merged
merged 3 commits into from
Oct 9, 2022
Merged

Add ptr::Alignment type #102072

merged 3 commits into from
Oct 9, 2022

Conversation

scottmcm
Copy link
Member

Essentially no new code here, just exposing the previously-pub(crate) ValidAlign type under the name from the ACP.

ACP: rust-lang/libs-team#108
Tracking Issue: #102070

r? @ghost

@scottmcm
Add ptr::Alignment type
585bcc6 
Essentially no new code here, just exposing the previously-`pub(crate)` `ValidAlign` type under the name from the ACP.
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 20, 2022
@scottmcm scottmcm mentioned this pull request Sep 20, 2022
Open
6 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@scottmcm scottmcm marked this pull request as ready for review September 21, 2022 22:06
@rustbot
Copy link
Collaborator

rustbot commented Sep 21, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@scottmcm
Copy link
Member Author

OP has the link to the relevant ACP
r? @m-ou-se
@rustbot label +T-libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Sep 21, 2022
@CraftSpider CraftSpider mentioned this pull request Sep 23, 2022
Merged
@scottmcm
Copy link
Member Author

Flipping to a non-api reviewer to help free up Mara, since the ACP is seconded
r? @thomcc

@rust-highfive rust-highfive assigned thomcc and unassigned m-ou-se Sep 30, 2022
@scottmcm scottmcm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 8, 2022
@thomcc
Copy link
Member

thomcc commented Oct 8, 2022

Looks great to me. I think it could use stuff like From<Alignment> for usize/NonZeroUsize, but as you mentioned in the ACP, this stuff is not needed from the start.

@bors r+

@bors
Copy link
Contributor

bors commented Oct 8, 2022

📌 Commit c158b7b has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 9, 2022
@Dylan-DPC
Rollup merge of rust-lang#102072 - scottmcm:ptr-alignment-type, r=thomcc
c4187f2 
Add `ptr::Alignment` type

Essentially no new code here, just exposing the previously-`pub(crate)` `ValidAlign` type under the name from the ACP.

ACP: rust-lang/libs-team#108
Tracking Issue: rust-lang#102070

r? `@ghost`
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 9, 2022
Closed
@JohnTitor JohnTitor mentioned this pull request Oct 9, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 9, 2022
@bors
Auto merge of rust-lang#102850 - JohnTitor:rollup-lze1w03, r=JohnTitor
81f3919 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#101118 (fs::get_mode enable getting the data via fcntl/F_GETFL on major BSD)
 - rust-lang#102072 (Add `ptr::Alignment` type)
 - rust-lang#102799 (rustdoc: remove hover gap in file picker)
 - rust-lang#102820 (Show let-else suggestion on stable.)
 - rust-lang#102829 (rename `ImplItemKind::TyAlias` to `ImplItemKind::Type`)
 - rust-lang#102831 (Don't use unnormalized type in `Ty::fn_sig` call in rustdoc `clean_middle_ty`)
 - rust-lang#102834 (Remove unnecessary `lift`/`lift_to_tcx` calls from rustdoc)
 - rust-lang#102838 (remove cfg(bootstrap) from Miri)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 38db483 into rust-lang:master Oct 9, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 9, 2022
@scottmcm scottmcm deleted the ptr-alignment-type branch October 9, 2022 21:51
@scottmcm scottmcm mentioned this pull request Oct 9, 2022
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 10, 2022
@JohnTitor
Rollup merge of rust-lang#102862 - scottmcm:more-alignment-traits, r=…
4d5b4a8 
…thomcc

From<Alignment> for usize & NonZeroUsize

Since you mentioned these two in rust-lang#102072 (comment),
r? `@thomcc`

Tracking Issue: rust-lang#102070
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 10, 2022
@JohnTitor
Rollup merge of rust-lang#102862 - scottmcm:more-alignment-traits, r=…
6d35efe 
…thomcc

From<Alignment> for usize & NonZeroUsize

Since you mentioned these two in rust-lang#102072 (comment),
r? ``@thomcc``

Tracking Issue: rust-lang#102070
@scottmcm scottmcm mentioned this pull request Nov 12, 2022
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 12, 2022
@GuillaumeGomez
Rollup merge of rust-lang#104308 - scottmcm:no-more-validalign, r=thomcc
ac21592 
Remove the old `ValidAlign` name

Since it looks like there won't be any reverts needed in `Layout` for rust-lang#101899 (comment), finish off this change that I'd left out of rust-lang#102072.

r? `@thomcc`
cc tracking issue rust-lang#102070
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 12, 2022
@GuillaumeGomez
Rollup merge of rust-lang#104308 - scottmcm:no-more-validalign, r=thomcc
f48dba1 
Remove the old `ValidAlign` name

Since it looks like there won't be any reverts needed in `Layout` for rust-lang#101899 (comment), finish off this change that I'd left out of rust-lang#102072.

r? ``@thomcc``
cc tracking issue rust-lang#102070
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 18, 2022
@Manishearth
Rollup merge of rust-lang#102207 - CraftSpider:const-layout, r=scottmcm
968b9d8 
Constify remaining `Layout` methods

Makes the methods on `Layout` that aren't yet unstably const, under the same feature and issue, rust-lang#67521. Most of them required no changes, only non-trivial change is probably constifying `ValidAlignment` which may affect rust-lang#102072
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 18, 2022
@Manishearth
Rollup merge of rust-lang#102207 - CraftSpider:const-layout, r=scottmcm
3c19543 
Constify remaining `Layout` methods

Makes the methods on `Layout` that aren't yet unstably const, under the same feature and issue, rust-lang#67521. Most of them required no changes, only non-trivial change is probably constifying `ValidAlignment` which may affect rust-lang#102072
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Nov 19, 2022
@Dylan-DPC
Rollup merge of rust-lang#102207 - CraftSpider:const-layout, r=scottmcm
4ca5ece 
Constify remaining `Layout` methods

Makes the methods on `Layout` that aren't yet unstably const, under the same feature and issue, rust-lang#67521. Most of them required no changes, only non-trivial change is probably constifying `ValidAlignment` which may affect rust-lang#102072
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 22, 2022
@Manishearth
Rollup merge of rust-lang#102207 - CraftSpider:const-layout, r=scottmcm
1625435 
Constify remaining `Layout` methods

Makes the methods on `Layout` that aren't yet unstably const, under the same feature and issue, rust-lang#67521. Most of them required no changes, only non-trivial change is probably constifying `ValidAlignment` which may affect rust-lang#102072
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#102850 - JohnTitor:rollup-lze1w03, r=JohnTitor
d7638ed 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#101118 (fs::get_mode enable getting the data via fcntl/F_GETFL on major BSD)
 - rust-lang#102072 (Add `ptr::Alignment` type)
 - rust-lang#102799 (rustdoc: remove hover gap in file picker)
 - rust-lang#102820 (Show let-else suggestion on stable.)
 - rust-lang#102829 (rename `ImplItemKind::TyAlias` to `ImplItemKind::Type`)
 - rust-lang#102831 (Don't use unnormalized type in `Ty::fn_sig` call in rustdoc `clean_middle_ty`)
 - rust-lang#102834 (Remove unnecessary `lift`/`lift_to_tcx` calls from rustdoc)
 - rust-lang#102838 (remove cfg(bootstrap) from Miri)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
thomcc pushed a commit to tcdi/postgrestd that referenced this pull request Feb 10, 2023
@JohnTitor
Rollup merge of #102862 - scottmcm:more-alignment-traits, r=thomcc
41e51f6 
From<Alignment> for usize & NonZeroUsize

Since you mentioned these two in rust-lang/rust#102072 (comment),
r? ``@thomcc``

Tracking Issue: rust-lang/rust#102070
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joboet joboet joboet left review comments

Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@scottmcm @rust-log-analyzer @rustbot @thomcc @bors @joboet @m-ou-se