Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRATER ONLY] Make opaque_hidden_inferred_bound lint a hard error #102593

Conversation

compiler-errors
Copy link
Member

For crater run only :)

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 2, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 2, 2022

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 2, 2022
@compiler-errors
Copy link
Member Author

oops, sorry. Should be a draft.

@compiler-errors
Copy link
Member Author

r? @compiler-errors

@compiler-errors compiler-errors marked this pull request as draft October 2, 2022 19:09
@compiler-errors
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Oct 2, 2022

⌛ Trying commit 0e734e1 with merge 34585ff556bad2462429cd3775623c743928a72f...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-13 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
..............................................i......................................... 4664/13618
........................................................................................ 4752/13618
........................................................................................ 4840/13618
........................................................................................ 4928/13618
..............................................................F...F..FFF....F........... 5016/13618
........................................................................................ 5192/13618
.........................................................................i.............. 5280/13618
.......................................................i................................ 5368/13618
........................................................................................ 5456/13618
---
---- [ui] src/test/ui/impl-trait/nested-return-type2-tait.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/impl-trait/nested-return-type2-tait.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/impl-trait/nested-return-type2-tait" "-A" "unused" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/impl-trait/nested-return-type2-tait/auxiliary"
stdout: none
--- stderr -------------------------------
error: opaque type `impl Trait<Assoc = Sendable>` does not satisfy its associated type bounds
   |
   |
LL |     type Assoc: Duh;
Some tests failed in compiletest suite=ui mode=ui host=x86_64-unknown-linux-gnu target=x86_64-unknown-linux-gnu
   |                 --- this associated type bound is unsatisfied for `Sendable`
...
LL | fn foo() -> impl Trait<Assoc = Sendable> {
   |
   = note: `#[deny(opaque_hidden_inferred_bound)]` on by default
help: add this bound
   |
   |
LL | type Sendable = impl Send + Duh;

error: aborting due to previous error
------------------------------------------



---- [ui] src/test/ui/impl-trait/nested-return-type2.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/impl-trait/nested-return-type2.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/impl-trait/nested-return-type2" "-A" "unused" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/impl-trait/nested-return-type2/auxiliary"
stdout: none
--- stderr -------------------------------
error: opaque type `impl Trait<Assoc = impl Send>` does not satisfy its associated type bounds
   |
   |
LL |     type Assoc: Duh;
   |                 --- this associated type bound is unsatisfied for `impl Send`
...
LL | fn foo() -> impl Trait<Assoc = impl Send> {
   |
   = note: `#[deny(opaque_hidden_inferred_bound)]` on by default
help: add this bound
   |
   |
LL | fn foo() -> impl Trait<Assoc = impl Send + Duh> {

error: aborting due to previous error
------------------------------------------



---- [ui] src/test/ui/impl-trait/nested-return-type3-tait.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/impl-trait/nested-return-type3-tait.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/impl-trait/nested-return-type3-tait" "-A" "unused" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/impl-trait/nested-return-type3-tait/auxiliary"
stdout: none
--- stderr -------------------------------
error: opaque type `impl Trait<Assoc = Sendable>` does not satisfy its associated type bounds
   |
   |
LL |     type Assoc: Duh;
   |                 --- this associated type bound is unsatisfied for `Sendable`
...
LL | fn foo() -> impl Trait<Assoc = Sendable> {
   |
   = note: `#[deny(opaque_hidden_inferred_bound)]` on by default
help: add this bound
   |
   |
LL | type Sendable = impl Send + Duh;

error: aborting due to previous error
------------------------------------------



---- [ui] src/test/ui/impl-trait/nested-return-type3-tait3.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/impl-trait/nested-return-type3-tait3.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/impl-trait/nested-return-type3-tait3" "-A" "unused" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/impl-trait/nested-return-type3-tait3/auxiliary"
stdout: none
--- stderr -------------------------------
error: opaque type `Traitable` does not satisfy its associated type bounds
   |
   |
LL |     type Assoc: Duh;
   |                 --- this associated type bound is unsatisfied for `impl Send`
...
LL | type Traitable = impl Trait<Assoc = impl Send>;
   |
   = note: `#[deny(opaque_hidden_inferred_bound)]` on by default
help: add this bound
   |
   |
LL | type Traitable = impl Trait<Assoc = impl Send + Duh>;

error: aborting due to previous error
------------------------------------------



---- [ui] src/test/ui/impl-trait/nested-return-type3-tait2.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/impl-trait/nested-return-type3-tait2.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/impl-trait/nested-return-type3-tait2" "-A" "unused" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/impl-trait/nested-return-type3-tait2/auxiliary"
stdout: none
--- stderr -------------------------------
error: opaque type `Traitable` does not satisfy its associated type bounds
   |
   |
LL |     type Assoc: Duh;
   |                 --- this associated type bound is unsatisfied for `Sendable`
...
LL | type Traitable = impl Trait<Assoc = Sendable>;
   |
   = note: `#[deny(opaque_hidden_inferred_bound)]` on by default
help: add this bound
   |
   |
LL | type Sendable = impl Send + Duh;

error: aborting due to previous error
------------------------------------------



---- [ui] src/test/ui/impl-trait/nested-return-type3.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/impl-trait/nested-return-type3.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/impl-trait/nested-return-type3" "-A" "unused" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/impl-trait/nested-return-type3/auxiliary"
stdout: none
--- stderr -------------------------------
error: opaque type `impl Trait<Assoc = impl Send>` does not satisfy its associated type bounds
   |
   |
LL |     type Assoc: Duh;
   |                 --- this associated type bound is unsatisfied for `impl Send`
...
LL | fn foo() -> impl Trait<Assoc = impl Send> {
   |
   = note: `#[deny(opaque_hidden_inferred_bound)]` on by default
help: add this bound
   |
   |
LL | fn foo() -> impl Trait<Assoc = impl Send + Duh> {

error: aborting due to previous error
------------------------------------------

@bors
Copy link
Contributor

bors commented Oct 2, 2022

☀️ Try build successful - checks-actions
Build commit: 34585ff556bad2462429cd3775623c743928a72f (34585ff556bad2462429cd3775623c743928a72f)

@compiler-errors
Copy link
Member Author

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-102593 created and queued.
🤖 Automatically detected try build 34585ff556bad2462429cd3775623c743928a72f
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2022
@craterbot
Copy link
Collaborator

🚧 Experiment pr-102593 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-102593 is completed!
📊 271 regressed and 9 fixed (244726 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Oct 4, 2022
@compiler-errors compiler-errors deleted the error-unsatisfied-opaques branch August 11, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants