Enable x.py check for miri

[oli-obk]

Now that the miri subtree is working properly, let's add it to x.py check.

cc @rust-lang/miri

[rust-highfive]

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

[RalfJung]

r? @RalfJung
r=me when CI is green

Was this the thing that caused doc failures? We might have to add that recursion limit attribute the error message was talking about...

[oli-obk]

@bors r=RalfJung

[bors]

📌 Commit 0227d8d has been approved by RalfJung

It is now in the queue for this repository.

[oli-obk]

@bors r=RalfJung

[bors]

📌 Commit c4b9b65 has been approved by RalfJung

It is now in the queue for this repository.

[matthiaskrgr]

@bors r- rollup=iffy failed in a rollup
#103097

[RalfJung]

All right, time for another attempt.
@bors r+

[bors]

📌 Commit f882309 has been approved by RalfJung

It is now in the queue for this repository.

[bors]

⌛ Testing commit f882309 with merge f46c1c5f28a0c1abeaf463951b7fe17eb40d5b26...

[bors]

💔 Test failed - checks-actions

[RalfJung]

Ah, that error is back

  = help: consider increasing the recursion limit by adding a `#![recursion_limit = "256"]` attribute to your crate (`miri`)

No idea why this occurs here, when actually generating the documentation for https://doc.rust-lang.org/nightly/nightly-rustc/miri/index.html works perfectly fine. But maybe we should just add that attribute? A lot of rustc crates seem to have it, too, possibly for the same reason.

[jyn514]

Ah, that error is back

  = help: consider increasing the recursion limit by adding a `#![recursion_limit = "256"]` attribute to your crate (`miri`)

No idea why this occurs here, when actually generating the documentation for https://doc.rust-lang.org/nightly/nightly-rustc/miri/index.html works perfectly fine. But maybe we should just add that attribute? A lot of rustc crates seem to have it, too, possibly for the same reason.

That seems reasonable. Bootstrap documents compiler crates with -Znormalize-docs so it doesn't surprise me that rustdoc hits the type length limit sooner than when rustc builds the crate.

[rustbot]

The Miri subtree was changed

cc @rust-lang/miri

[RalfJung]

Okay, let's do that then -- I pushed it to this PR.
@bors r+

[bors]

📌 Commit b35e2bf has been approved by RalfJung

It is now in the queue for this repository.

[bors]

⌛ Testing commit b35e2bf with merge 024207a...

[bors]

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 024207a to master...

[rust-timer]

Finished benchmarking commit (024207a): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.3%	[-1.4%, -1.2%]	2
Improvements ✅ (secondary)	-3.5%	[-4.0%, -3.1%]	6
All ❌✅ (primary)	-1.3%	[-1.4%, -1.2%]	2

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.