Improve docs for struct_lint_level function.
#102953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
RalfJung
reviewed
Oct 12, 2022
There was a problem hiding this comment.
The comment looks good, thanks! I left some suggestions.
There are a bunch of other functions also talking such a closure though. If I am calling tcx.struct_span_lint_hir I will still be confused. Could you add a comment to all of them just briefly stating that the return value is ignored and pointing to struct_lint_level?
Co-authored-by: Ralf Jung <post@ralfj.de>
|
I've applied the suggestions from review, this can be reviewed again. |
RalfJung
reviewed
Oct 16, 2022
|
Looks good, thanks a lot! |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 16, 2022
…ate_param, r=RalfJung Improve docs for `struct_lint_level` function. r? `@RalfJung` Does this answer your questions?
This was referenced Oct 16, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 16, 2022
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#102857 (Add a regression test for rust-lang#39137) - rust-lang#102953 (Improve docs for `struct_lint_level` function.) - rust-lang#103060 (rustdoc: make the help button a link to a page) - rust-lang#103115 (Clean up anchors.goml rustdoc GUI test) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @RalfJung
Does this answer your questions?