pretty: fix to print some lifetimes on HIR pretty-print

[ohno418]

HIR pretty-printer doesn't seem to print some lifetimes in types. This PR fixes that.

Closes #85089

[rust-highfive]

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

[ohno418]

A bit messy around here. I feel like if any better way.

[cjgillot]

Could you replace this branch by changing the if nonelided_generic_args to if nonelided_generic_args || !elide_lifetimes below the loop?

[ohno418]

Yeah, that would work fine. But I have a concern that it would make nonelided_generic_args differ from what is inferred from its name.
Because in that case, nonelided_generic_args can be false, even when we have lifetime generic_args that are not elided.

Isn't it a concern that much? (or do I understand wrong?)

[cjgillot]

nonelided_generic_args is only used in one place, just below, so I'm not really concerned. If you want to fix that, you can change the name.
Another possibility: make lt.is_elided() into an arm guard, and let the non-elided case fall through the _ => case.
I'll let this to your judgement.

[ohno418]

nonelided_generic_args is only used in one place, just below, so I'm not really concerned.

Ah, indeed.

Another possibility: make lt.is_elided() into an arm guard, and let the non-elided case fall through the _ => case.

Thanks for the suggestion! I prefer this one a bit. But looks like non-elided case cannot fall to the _ => case, so may be like this:

                GenericArg::Lifetime(lt) if lt.is_elided() => true,
                GenericArg::Lifetime(_) => {
                    nonelided_generic_args = true;
                    false
                }
                _ => {
                    nonelided_generic_args = true;
                    true
                }

[ohno418]

done.

[cjgillot]

Thanks!
@bors r+ rollup

[bors]

📌 Commit 7334526 has been approved by cjgillot

It is now in the queue for this repository.