Delay ambiguity span bug in normalize query iff not rustdoc #103368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
T-compiler
|
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @oli-obk |
compiler-errors
force-pushed
the
normalization-ambiguity-bug
branch
from
c47d3b4
to
684c134
Compare
compiler-errors
force-pushed
the
normalization-ambiguity-bug
branch
from
684c134
to
cb61113
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
|
Ugh, fine. I imagine this will be moot in the long-term anyways. |
Yea, these can probably be reverted by not throwing away binders in rustdoc. But beta cutoff is next week or so. I am planning on mentoring someone who likely wants to learn about binders and this is a good entry level work for that |
notriddle
added a commit
to notriddle/rust
that referenced
this pull request
Oct 22, 2022
…guity-bug, r=oli-obk Delay ambiguity span bug in normalize query iff not rustdoc Oli and I decided that the compiler debt of adding another usage of `tcx.sess.opts.actually_rustdoc` is fine, because we don't really want to add more complexity to the normalize query, and moving rustdoc to use fulfill normalization (`fully_normalize`, i.e. not use the normalize query) is unnecessary overhead given that it's skipping binders and stuff. r? oli-obk Fixes rust-lang#102827 Fixes rust-lang#103181
notriddle
added a commit
to notriddle/rust
that referenced
this pull request
Oct 22, 2022
…guity-bug, r=oli-obk Delay ambiguity span bug in normalize query iff not rustdoc Oli and I decided that the compiler debt of adding another usage of `tcx.sess.opts.actually_rustdoc` is fine, because we don't really want to add more complexity to the normalize query, and moving rustdoc to use fulfill normalization (`fully_normalize`, i.e. not use the normalize query) is unnecessary overhead given that it's skipping binders and stuff. r? oli-obk Fixes rust-lang#102827 Fixes rust-lang#103181
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 23, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#103123 (Introduce `subst_iter` and `subst_iter_copied` on `EarlyBinder` ) - rust-lang#103328 (Do not suggest trivially false const predicates) - rust-lang#103354 (Escape string literals when fixing overlong char literal) - rust-lang#103355 (Handle return-position `impl Trait` in traits properly in `register_hidden_type`) - rust-lang#103368 (Delay ambiguity span bug in normalize query iff not rustdoc) - rust-lang#103388 (rustdoc: remove unused CSS class `.result-description`) - rust-lang#103399 (Change `unknown_lint` applicability to `MaybeIncorrect`) - rust-lang#103401 (Use functions for headings rustdoc GUI test) - rust-lang#103412 (Fix typo in docs of `String::leak`.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oli and I decided that the compiler debt of adding another usage of
tcx.sess.opts.actually_rustdocis fine, because we don't really want to add more complexity to the normalize query, and moving rustdoc to use fulfill normalization (fully_normalize, i.e. not use the normalize query) is unnecessary overhead given that it's skipping binders and stuff.r? oli-obk
Fixes #102827
Fixes #103181