Rollup of 9 pull requests #103426
Merged
Rollup of 9 pull requests #103426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was added to the CSS in d8de2b4, but was never actually used in that PR.
… r=cjgillot Introduce `subst_iter` and `subst_iter_copied` on `EarlyBinder` Makes working with bounds lists a bit easier, which I seem to do a lot. Specifically, means that we don't need to do `.transpose_iter().map(|(pred, _)| *pred)` every time we want to iterate through an `EarlyBinder<&'tcx [(Predicate, Span)]>` (and even then, still have to call `subst` later), which was a very awkward idiom imo.
…t-sugg, r=jackh726 Do not suggest trivially false const predicates Pass through constness to `predicate_can_apply` and don't suggest other impls if it's satisfied but not const. Fixes rust-lang#103267
…r=compiler-errors Escape string literals when fixing overlong char literal Fixes rust-lang#103323 ````@rustbot```` label +A-diagnostics +A-suggestion-diagnostics
…ck, r=oli-obk Handle return-position `impl Trait` in traits properly in `register_hidden_type` The bounds that we get by calling `bound_explicit_item_bounds` from an RPITIT have projections, not opaques, but when we're *registering* an opaque, we want to treat it like an opaque. Coincidentally fixes rust-lang#102688 as well, which makes sense, since that was failing because we were inferring an opaque type to be equal to itself (opaque cycle error => "cannot resolve opaque type"). Fixes rust-lang#103352 r? ```@oli-obk```
…guity-bug, r=oli-obk Delay ambiguity span bug in normalize query iff not rustdoc Oli and I decided that the compiler debt of adding another usage of `tcx.sess.opts.actually_rustdoc` is fine, because we don't really want to add more complexity to the normalize query, and moving rustdoc to use fulfill normalization (`fully_normalize`, i.e. not use the normalize query) is unnecessary overhead given that it's skipping binders and stuff. r? oli-obk Fixes rust-lang#102827 Fixes rust-lang#103181
…tion, r=GuillaumeGomez rustdoc: remove unused CSS class `.result-description` It was added to the CSS in d8de2b4, but was never actually used in that PR.
…ect, r=fee1-dead Change `unknown_lint` applicability to `MaybeIncorrect` This small PR changes the applicability of `unknown_lint` to `MaybeIncorrect`, because the suggested lint might not be the correct one. Here is one example where the current applicability causes a problem. Clippy has a set of internal lints guarded by a feature called `internal`. If the feature is not enabled, then the internal lints are "unknown." In that case, running `cargo clippy --fix ...` on `clippy_utils` causes lines such as the followig https://github.com/rust-lang/rust/blob/26c96e341639102afacbbcad0dc18ad0ac71ab18/src/tools/clippy/clippy_utils/src/paths.rs#L51-L52 to be changed to ```rust #[expect(clippy::invalid_regex)] // internal lints do not know about all external crates pub const FUTURES_IO_ASYNCREADEXT: [&str; 3] = ["futures_util", "io", "AsyncReadExt"]; ``` which is not correct.
…leanup, r=notriddle Use functions for headings rustdoc GUI test r? ````@notriddle````
…, r=thomcc Fix typo in docs of `String::leak`. I introduced a typo in rust-lang#103280, this PR fixes it. See rust-lang#103280 (comment)
rustbot
added
T-compiler
|
@bors r+ rollup=never p=9 |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: 6c9c2d862d In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Oct 23, 2022
|
Finished benchmarking commit (faab68e): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
subst_iterandsubst_iter_copiedonEarlyBinder#103123 (Introducesubst_iterandsubst_iter_copiedonEarlyBinder)impl Traitin traits properly inregister_hidden_type#103355 (Handle return-positionimpl Traitin traits properly inregister_hidden_type).result-description#103388 (rustdoc: remove unused CSS class.result-description)unknown_lintapplicability toMaybeIncorrect#103399 (Changeunknown_lintapplicability toMaybeIncorrect)String::leak. #103412 (Fix typo in docs ofString::leak.)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup