Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document split{_ascii,}_whitespace() for empty strings #104774

Merged
merged 1 commit into from
Nov 25, 2022
Merged

Document split{_ascii,}_whitespace() for empty strings #104774

merged 1 commit into from
Nov 25, 2022

Conversation

vojtechkral
Copy link
Contributor

@vojtechkral vojtechkral commented Nov 23, 2022 •
edited
Loading

doc change only

@rustbot
Copy link
Collaborator

rustbot commented Nov 23, 2022

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 23, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 23, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@thomcc
Copy link
Member

thomcc commented Nov 23, 2022

Seems fine. This was already the behavior deliberately and isn't a new guarantee.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 23, 2022

📌 Commit 9a2b955 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 23, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Nov 24, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Nov 24, 2022
@Dylan-DPC
Rollup merge of rust-lang#104774 - vojtechkral:doc-str-empty-split-wh…
294441e 
…itespace, r=thomcc

Document split{_ascii,}_whitespace() for empty strings

doc change only
@thomcc
Copy link
Member

thomcc commented Nov 24, 2022

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 24, 2022
@thomcc
Copy link
Member

thomcc commented Nov 24, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 24, 2022

📌 Commit 07ccf67 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 24, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 24, 2022
@matthiaskrgr
Rollup merge of rust-lang#104774 - vojtechkral:doc-str-empty-split-wh…
70fe3bc 
…itespace, r=thomcc

Document split{_ascii,}_whitespace() for empty strings

doc change only
This was referenced Nov 24, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 24, 2022
@bors
Auto merge of rust-lang#104845 - matthiaskrgr:rollup-tckj956, r=matth…
65a6e22 
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#104514 (Use node_ty_opt to avoid ICE in visit_ty)
 - rust-lang#104704 (Allow power10-vector feature in PowerPC)
 - rust-lang#104747 (resolve: Don't use constructor def ids in the map for field names)
 - rust-lang#104773 (OpaqueCast projections are always overlapping, they can't possibly be disjoint)
 - rust-lang#104774 (Document split{_ascii,}_whitespace() for empty strings)
 - rust-lang#104780 (make `error_reported` check for delayed bugs)
 - rust-lang#104782 (Bump the const eval step limit)
 - rust-lang#104792 (rustdoc: simplify `.search-results-title` CSS)
 - rust-lang#104796 (lint: do not warn unused parens around higher-ranked function pointers)
 - rust-lang#104820 (Remove normalize_projection_type)
 - rust-lang#104822 (with_query_mode -> new)

Failed merges:

 - rust-lang#104716 (move 2 candidates into builtin candidate)
 - rust-lang#104841 (Assert that we don't capture escaping bound vars in `Fn` trait selection)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d4e5418 into rust-lang:master Nov 25, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 25, 2022
@vojtechkral vojtechkral deleted the doc-str-empty-split-whitespace branch November 25, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eminence eminence eminence left review comments

@thomcc thomcc thomcc left review comments

Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vojtechkral @rustbot @thomcc @bors @eminence