Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert that we don't capture escaping bound vars in Fn trait selection #104841

Merged
merged 3 commits into from
Nov 25, 2022
Merged

Assert that we don't capture escaping bound vars in Fn trait selection #104841

merged 3 commits into from
Nov 25, 2022

Conversation

compiler-errors
Copy link
Member

Fixes #104825

@rustbot
Copy link
Collaborator

rustbot commented Nov 24, 2022

r? @estebank

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 24, 2022
@jackh726
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 24, 2022

📌 Commit 770c3416aa3798ea7c003946a1999bc948b8b961 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2022
@compiler-errors
Copy link
Member Author

Hold up, wanted to add a check for fn pointers too while we're at it.

@jackh726
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 24, 2022

📌 Commit 86c5f0a8347c7b0eea54e9770979a46437a43a68 has been approved by jackh726

It is now in the queue for this repository.

@oli-obk
Copy link
Contributor

oli-obk commented Nov 24, 2022

@bors r=jackh726

@bors
Copy link
Contributor

bors commented Nov 24, 2022

📌 Commit 581ee96d40314cc88d6a5698c1da7eed8e8fb37d has been approved by jackh726

It is now in the queue for this repository.

@matthiaskrgr matthiaskrgr mentioned this pull request Nov 24, 2022
Merged
@bors
Copy link
Contributor

bors commented Nov 24, 2022

☔ The latest upstream changes (presumably #104321) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 24, 2022
@compiler-errors
Copy link
Member Author

@bors r=jackh726

@bors
Copy link
Contributor

bors commented Nov 24, 2022

📌 Commit d945967 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 24, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 24, 2022
@bors
Auto merge of rust-lang#104845 - matthiaskrgr:rollup-tckj956, r=matth…
65a6e22 
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#104514 (Use node_ty_opt to avoid ICE in visit_ty)
 - rust-lang#104704 (Allow power10-vector feature in PowerPC)
 - rust-lang#104747 (resolve: Don't use constructor def ids in the map for field names)
 - rust-lang#104773 (OpaqueCast projections are always overlapping, they can't possibly be disjoint)
 - rust-lang#104774 (Document split{_ascii,}_whitespace() for empty strings)
 - rust-lang#104780 (make `error_reported` check for delayed bugs)
 - rust-lang#104782 (Bump the const eval step limit)
 - rust-lang#104792 (rustdoc: simplify `.search-results-title` CSS)
 - rust-lang#104796 (lint: do not warn unused parens around higher-ranked function pointers)
 - rust-lang#104820 (Remove normalize_projection_type)
 - rust-lang#104822 (with_query_mode -> new)

Failed merges:

 - rust-lang#104716 (move 2 candidates into builtin candidate)
 - rust-lang#104841 (Assert that we don't capture escaping bound vars in `Fn` trait selection)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 25, 2022
@matthiaskrgr
Rollup merge of rust-lang#104841 - compiler-errors:fishy-bound-var, r…
11d840c 
…=jackh726

Assert that we don't capture escaping bound vars in `Fn` trait selection

Fixes rust-lang#104825
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 25, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 25, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 25, 2022
@bors
Auto merge of rust-lang#104877 - matthiaskrgr:rollup-s7taiq8, r=matth…
e704e95 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#103648 (Don't set `is_preview` for clippy and rustfmt)
 - rust-lang#104654 (Add `#![deny(unsafe_op_in_unsafe_fn)]` in liballoc tests)
 - rust-lang#104793 (unstable-book: Add page for the `abi_efiapi` feature)
 - rust-lang#104841 (Assert that we don't capture escaping bound vars in `Fn` trait selection)
 - rust-lang#104849 (Migrate source code elements style to CSS variables)
 - rust-lang#104873 (RefCell::get_mut: fix typo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 34f1de8 into rust-lang:master Nov 25, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 25, 2022
@compiler-errors compiler-errors deleted the fishy-bound-var branch August 11, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

"fishy" skip_binder actually ignoring bound variables
6 participants
@compiler-errors @rustbot @jackh726 @bors @oli-obk @estebank