kmc-solid: `std::sys` code maintenance #105120

kawadakk · 2022-12-01T08:48:44Z

Includes a set of changes to fix the *-kmc-solid_* Tier 3 targets and make some other improvements.

Address fuzzy_provenance_casts by using expose_addr and from_exposed_addr for pointer-integer casts
Add a stub implementation of is_terminal (Tracking Issue for IsTerminal / is_terminal #98070)
Address unused_imports and unused_unsafe
Stop doing Box::from_raw(&*(x: Box<T>) as *const T as *mut T)

…ger casts Pointer-integer casts are required for conversion between `EXINF` (ITRON task entry point parameter) and `*const ThreadInner`. Addresses the deny-level lint `fuzzy_provenance_casts`.

Copied from `unsupported/io.rs`. Fixes build failure.

Addresses the warn-by-default lints `unused_imports` and `unused_unsafe`.

rustbot · 2022-12-01T08:48:52Z

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2022-12-01T08:48:54Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

library/std/src/sys/itron/thread.rs

workingjubilee

I have some small questions, as I would like to understand the various implementations of std::sys code better, if you don't mind?

library/std/src/sys/itron/thread.rs

workingjubilee · 2022-12-01T10:10:34Z

library/std/src/sys/itron/thread.rs

+// Safety: `Thread` provides no methods that take `&self`.
+unsafe impl Sync for Thread {}


It's not intuitive to me that implementing a function or not that takes &self affects safety for this case, as borrowing is a primitive notion in Rust, so anyone can hypothetically take &Thread from a given Thread and run off with it? Could you explain that one?

This is the same reasoning as the one for Exclusive: since you cannot do anything with the reference, the struct can be Sync without causing any UB.

I'm not sure this is the best reasoning here, but it is correct.

Oh I see, so it's actually talking about Thread as a "smart pointer" (wrapper around the pointer). It interposes and blocks access to the pointer inside, and then never allows you to touch that inner pointer using a method that would take &Thread. Thus it's correct to unsafe impl Sync for Thread, since the behavior of the type can only be accessed via &mut Thread or Thread.

Yeah for some reason that didn't actually register immediately when I read it.

library/std/src/sys/itron/thread.rs

This pattern seems to be considered illegal by Miri.

thomcc · 2022-12-07T09:39:09Z

Sorry for the delay. This looks fine to me.

@bors r+

bors · 2022-12-07T09:39:11Z

📌 Commit ae7633f has been approved by thomcc

It is now in the queue for this repository.

bors · 2022-12-08T01:45:05Z

⌛ Testing commit ae7633f with merge a1b3b216ea701185366880c7c45c75727bd8c630...

bors · 2022-12-08T02:03:28Z

💔 Test failed - checks-actions

ehuss · 2022-12-08T02:40:29Z

@bors retry

Failed to update toolstate
(has been fixed)

…nce, r=thomcc kmc-solid: `std::sys` code maintenance Includes a set of changes to fix the [`*-kmc-solid_*`](https://doc.rust-lang.org/nightly/rustc/platform-support/kmc-solid.html) Tier 3 targets and make some other improvements. - Address `fuzzy_provenance_casts` by using `expose_addr` and `from_exposed_addr` for pointer-integer casts - Add a stub implementation of `is_terminal` (rust-lang#98070) - Address `unused_imports` and `unused_unsafe` - Stop doing `Box::from_raw(&*(x: Box<T>) as *const T as *mut T)`

…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#104922 (Detect long types in E0308 and write them to disk) - rust-lang#105120 (kmc-solid: `std::sys` code maintenance) - rust-lang#105255 (Make nested RPIT inherit the parent opaque's generics.) - rust-lang#105317 (make retagging work even with 'unstable' places) - rust-lang#105405 (Stop passing -export-dynamic to wasm-ld.) - rust-lang#105408 (Add help for `#![feature(impl_trait_in_fn_trait_return)]`) - rust-lang#105423 (Use `Symbol` for the crate name instead of `String`/`str`) - rust-lang#105433 (CI: add missing line continuation marker) - rust-lang#105434 (Fix warning when libcore is compiled with no_fp_fmt_parse) - rust-lang#105441 (Remove `UnsafetyState`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2022-12-09T04:55:41Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

 * branch            master     -> FETCH_HEAD
HEAD is now at 496fb40 (windows CI update)
[master 5284f17] (linux CI update)
 1 file changed, 1 insertion(+)
fatal: could not read Username for 'https://github.com': No such device or address
Sleeping for 3 seconds before retrying push
 * branch            master     -> FETCH_HEAD
HEAD is now at 496fb40 (windows CI update)
[master 5f5033b] (linux CI update)
 1 file changed, 1 insertion(+)
 1 file changed, 1 insertion(+)
fatal: could not read Username for 'https://github.com': No such device or address
Sleeping for 3 seconds before retrying push
 * branch            master     -> FETCH_HEAD
HEAD is now at 496fb40 (windows CI update)
[master e34230a] (linux CI update)
 1 file changed, 1 insertion(+)
 1 file changed, 1 insertion(+)
fatal: could not read Username for 'https://github.com': No such device or address
Sleeping for 3 seconds before retrying push
 * branch            master     -> FETCH_HEAD
HEAD is now at 496fb40 (windows CI update)
[master 87448e3] (linux CI update)
 1 file changed, 1 insertion(+)
 1 file changed, 1 insertion(+)
fatal: could not read Username for 'https://github.com': No such device or address
Sleeping for 3 seconds before retrying push
 * branch            master     -> FETCH_HEAD
 * branch            master     -> FETCH_HEAD
thread 'main' panicked at 'Failed to update toolstate repository with new data', toolstate.rs:436:9
HEAD is now at 496fb40 (windows CI update)
Build completed unsuccessfully in 0:00:19

…nce, r=thomcc kmc-solid: `std::sys` code maintenance Includes a set of changes to fix the [`*-kmc-solid_*`](https://doc.rust-lang.org/nightly/rustc/platform-support/kmc-solid.html) Tier 3 targets and make some other improvements. - Address `fuzzy_provenance_casts` by using `expose_addr` and `from_exposed_addr` for pointer-integer casts - Add a stub implementation of `is_terminal` (rust-lang#98070) - Address `unused_imports` and `unused_unsafe` - Stop doing `Box::from_raw(&*(x: Box<T>) as *const T as *mut T)`

…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#104922 (Detect long types in E0308 and write them to disk) - rust-lang#105120 (kmc-solid: `std::sys` code maintenance) - rust-lang#105255 (Make nested RPIT inherit the parent opaque's generics.) - rust-lang#105317 (make retagging work even with 'unstable' places) - rust-lang#105405 (Stop passing -export-dynamic to wasm-ld.) - rust-lang#105408 (Add help for `#![feature(impl_trait_in_fn_trait_return)]`) - rust-lang#105423 (Use `Symbol` for the crate name instead of `String`/`str`) - rust-lang#105433 (CI: add missing line continuation marker) - rust-lang#105434 (Fix warning when libcore is compiled with no_fp_fmt_parse) - rust-lang#105441 (Remove `UnsafetyState`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

kawadakk added 3 commits December 1, 2022 13:18

kmc-solid: Use expose_addr and from_exposed_addr for pointer-inte…

427a079

…ger casts Pointer-integer casts are required for conversion between `EXINF` (ITRON task entry point parameter) and `*const ThreadInner`. Addresses the deny-level lint `fuzzy_provenance_casts`.

kmc-solid: Add a stub implementation of is_terminal

47f2f6d

Copied from `unsupported/io.rs`. Fixes build failure.

kmc-solid: Address compiler warnings

f482e55

Addresses the warn-by-default lints `unused_imports` and `unused_unsafe`.

rustbot assigned thomcc Dec 1, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 1, 2022

Nilstrieb reviewed Dec 1, 2022

View reviewed changes

library/std/src/sys/itron/thread.rs Outdated Show resolved Hide resolved

workingjubilee reviewed Dec 1, 2022

View reviewed changes

kmc-solid: Don't do Box::from_raw(&*(x: Box<T>) as *const T as *mut T)

ae7633f

This pattern seems to be considered illegal by Miri.

kawadakk force-pushed the patch/kmc-solid/maintainance branch from f7e0d3d to ae7633f Compare December 2, 2022 07:59

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 7, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 8, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 8, 2022

matthiaskrgr mentioned this pull request Dec 8, 2022

Rollup of 9 pull requests #105444

Closed

matthiaskrgr mentioned this pull request Dec 8, 2022

Rollup of 8 pull requests #105448

Closed

matthiaskrgr mentioned this pull request Dec 8, 2022

Rollup of 10 pull requests #105456

Merged

bors merged commit cd936cc into rust-lang:master Dec 9, 2022

rustbot added this to the 1.67.0 milestone Dec 9, 2022

kawadakk deleted the patch/kmc-solid/maintainance branch December 9, 2022 06:25

albertlarsan68 mentioned this pull request Jan 9, 2023

Regression in Beta/Nightly: implementation of Trait is not general enough #106630

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kmc-solid: `std::sys` code maintenance #105120

kmc-solid: `std::sys` code maintenance #105120

kawadakk commented Dec 1, 2022

rustbot commented Dec 1, 2022

rustbot commented Dec 1, 2022

workingjubilee left a comment

workingjubilee Dec 1, 2022

joboet Dec 1, 2022

workingjubilee Dec 1, 2022

thomcc commented Dec 7, 2022

bors commented Dec 7, 2022

bors commented Dec 8, 2022

bors commented Dec 8, 2022

ehuss commented Dec 8, 2022

rust-log-analyzer commented Dec 9, 2022

		// Safety: `Thread` provides no methods that take `&self`.
		unsafe impl Sync for Thread {}

kmc-solid: std::sys code maintenance #105120

kmc-solid: std::sys code maintenance #105120

Conversation

kawadakk commented Dec 1, 2022

rustbot commented Dec 1, 2022

rustbot commented Dec 1, 2022

workingjubilee left a comment

Choose a reason for hiding this comment

workingjubilee Dec 1, 2022

Choose a reason for hiding this comment

joboet Dec 1, 2022

Choose a reason for hiding this comment

workingjubilee Dec 1, 2022

Choose a reason for hiding this comment

thomcc commented Dec 7, 2022

bors commented Dec 7, 2022

bors commented Dec 8, 2022

bors commented Dec 8, 2022

ehuss commented Dec 8, 2022

rust-log-analyzer commented Dec 9, 2022

kmc-solid: `std::sys` code maintenance #105120

kmc-solid: `std::sys` code maintenance #105120