Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UnsafetyState #105441

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Remove UnsafetyState #105441

merged 2 commits into from
Dec 9, 2022

Conversation

nnethercote
Copy link
Contributor

r? @lcnr

@nnethercote
Remove UnsafetyState.
7a46692 
`FnCtxt::ps` is the only occurrence. It gets updated during HIR
typechecking, but is never looked at.
@nnethercote
Fix a typo.
9af48e5
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 8, 2022
@nnethercote nnethercote changed the title Rm unsafety state Remove UnsafetyState Dec 8, 2022
@nnethercote
Copy link
Contributor Author

@bors rollup

@compiler-errors
Copy link
Member

I wonder when this field first started being useless 😆

@lcnr
Copy link
Contributor

lcnr commented Dec 8, 2022

probably when we removed RegionCtxt in #98584 🤔

@bors r+

@bors
Copy link
Contributor

bors commented Dec 8, 2022

📌 Commit 9af48e5 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 8, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 8, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 9, 2022
@bors
Auto merge of rust-lang#105456 - matthiaskrgr:rollup-yennygf, r=matth…
7701a7e 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#104922 (Detect long types in E0308 and write them to disk)
 - rust-lang#105120 (kmc-solid: `std::sys` code maintenance)
 - rust-lang#105255 (Make nested RPIT inherit the parent opaque's generics.)
 - rust-lang#105317 (make retagging work even with 'unstable' places)
 - rust-lang#105405 (Stop passing -export-dynamic to wasm-ld.)
 - rust-lang#105408 (Add help for `#![feature(impl_trait_in_fn_trait_return)]`)
 - rust-lang#105423 (Use `Symbol` for the crate name instead of `String`/`str`)
 - rust-lang#105433 (CI: add missing line continuation marker)
 - rust-lang#105434 (Fix warning when libcore is compiled with no_fp_fmt_parse)
 - rust-lang#105441 (Remove `UnsafetyState`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 660795e into rust-lang:master Dec 9, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 9, 2022
@nnethercote nnethercote deleted the rm-UnsafetyState branch December 9, 2022 06:46
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@matthiaskrgr
Rollup merge of rust-lang#105441 - nnethercote:rm-UnsafetyState, r=lcnr
51f7122 
Remove `UnsafetyState`

r? `@lcnr`
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#105456 - matthiaskrgr:rollup-yennygf, r=matth…
0208c4c 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#104922 (Detect long types in E0308 and write them to disk)
 - rust-lang#105120 (kmc-solid: `std::sys` code maintenance)
 - rust-lang#105255 (Make nested RPIT inherit the parent opaque's generics.)
 - rust-lang#105317 (make retagging work even with 'unstable' places)
 - rust-lang#105405 (Stop passing -export-dynamic to wasm-ld.)
 - rust-lang#105408 (Add help for `#![feature(impl_trait_in_fn_trait_return)]`)
 - rust-lang#105423 (Use `Symbol` for the crate name instead of `String`/`str`)
 - rust-lang#105433 (CI: add missing line continuation marker)
 - rust-lang#105434 (Fix warning when libcore is compiled with no_fp_fmt_parse)
 - rust-lang#105441 (Remove `UnsafetyState`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@albertlarsan68 albertlarsan68 mentioned this pull request Jan 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nnethercote @compiler-errors @lcnr @bors @rustbot