Fix passing MACOSX_DEPLOYMENT_TARGET to the linker #105123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
These commits modify compiler targets. |
This comment has been minimized.
This comment has been minimized.
BlackHoleFox
force-pushed
the
fixing-the-macos-deployment
branch
from
6af3f42
to
fde09c1
Compare
|
@rustbot label O-macos |
oli-obk
reviewed
Dec 1, 2022
|
@thomcc @petrochenkov do you want to have a look at this considering you reviewed the original PR? |
petrochenkov
approved these changes
Dec 1, 2022
BlackHoleFox
force-pushed
the
fixing-the-macos-deployment
branch
from
fde09c1
to
b5fa9af
Compare
thomcc
reviewed
Dec 2, 2022
BlackHoleFox
force-pushed
the
fixing-the-macos-deployment
branch
from
b5fa9af
to
56592d3
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 4, 2022
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#104856 (Don't suggest associated function call for associated const.) - rust-lang#105123 (Fix passing MACOSX_DEPLOYMENT_TARGET to the linker) - rust-lang#105142 (Make inline const block `ExprWithBlock`) - rust-lang#105237 (Add regression test for rust-lang#79450) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This was referenced Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I messed up in #103929 when merging the two base files together and as a result, started ignoring
MACOSX_DEPLOYMENT_TARGETat the linker level. This ended up being the cause of nighty builds not running on older macOS versions.My original hope with the previous PR was that CI would have caught something like that but there were only tests checking the compiler target definitions in codegen tests. Because of how badly this sucks to break, I put together a new test via
run-makethat actually confirms the deployment target set makes it to the linker instead of just LLVM.Closes #104570 (for real this time)