Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make inline const block ExprWithBlock #105142

Merged
merged 1 commit into from Dec 4, 2022
Merged

Make inline const block ExprWithBlock #105142

merged 1 commit into from Dec 4, 2022

Conversation

nbdd0121
Copy link
Contributor

@nbdd0121 nbdd0121 commented Dec 1, 2022

Fix #104087 (comment)

@rustbot label: +T-lang +F-inline_const

@rustbot
Copy link
Collaborator

rustbot commented Dec 1, 2022

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. F-inline_const Inline constants (aka: const blocks, const expressions, anonymous constants) T-lang Relevant to the language team, which will review and decide on the PR/issue. labels Dec 1, 2022
@petrochenkov
Copy link
Contributor

Yeah, I think it was just a mistake during the original implementation.
@bors r+

@bors
Copy link
Contributor

bors commented Dec 2, 2022

📌 Commit 171b7d6 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 4, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 4, 2022
@bors
Auto merge of rust-lang#105248 - matthiaskrgr:rollup-d56k6bc, r=matth…
344889e 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#104856 (Don't suggest associated function call for associated const.)
 - rust-lang#105123 (Fix passing MACOSX_DEPLOYMENT_TARGET to the linker)
 - rust-lang#105142 (Make inline const block `ExprWithBlock`)
 - rust-lang#105237 (Add regression test for rust-lang#79450)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3c4a430 into rust-lang:master Dec 4, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 4, 2022
@fmease fmease mentioned this pull request Dec 4, 2022
Closed
@nbdd0121 nbdd0121 mentioned this pull request Dec 14, 2022
Merged
@lukas-code lukas-code mentioned this pull request Dec 19, 2022
Merged
@nbdd0121 nbdd0121 deleted the inline_const branch December 22, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
F-inline_const Inline constants (aka: const blocks, const expressions, anonymous constants) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nbdd0121 @rustbot @petrochenkov @bors