rustdoc: remove no-op mobile CSS #sidebar-toggle { text-align }
#105480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 8b001b4 make the sidebar toggle a flex container, and already centers its content in desktop mode, this rule doesn't do anything.
|
r? @jsha (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
GuillaumeGomez
approved these changes
Dec 9, 2022
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Dec 9, 2022
…-mobile-center, r=GuillaumeGomez
rustdoc: remove no-op mobile CSS `#sidebar-toggle { text-align }`
Since 8b001b4 make the sidebar toggle a flex container, and already centers its content in desktop mode, this rule doesn't do anything.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 10, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#102406 (Make `missing_copy_implementations` more cautious) - rust-lang#105265 (Add `rustc_on_unimplemented` to `Sum` and `Product` trait.) - rust-lang#105385 (Skip test on s390x as LLD does not support the platform) - rust-lang#105453 (Make `VecDeque::from_iter` O(1) from `vec(_deque)::IntoIter`) - rust-lang#105468 (Mangle "main" as "__main_void" on wasm32-wasi) - rust-lang#105480 (rustdoc: remove no-op mobile CSS `#sidebar-toggle { text-align }`) - rust-lang#105489 (Fix typo in apple_base.rs) - rust-lang#105504 (rustdoc: make stability badge CSS more consistent) - rust-lang#105506 (Tweak `rustc_must_implement_one_of` diagnostic output) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 8b001b4 make the sidebar toggle a flex container, and already centers its content in desktop mode, this rule doesn't do anything.