Avoid going through the happy path in case of non-fn builtin calls

[oli-obk]

No functional change, just doing an early return. The removed comment is not applicable anymore, not every node needs type bindings in the error case. At best this would have been needed to avoid ICEs, but afaict this can't happen anymore today, as we do fallible checks.

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jackh726 (or someone else) soon.

Please see the contribution instructions for more information.

[jackh726]

@bors r+

[bors]

📌 Commit 1c5b53b has been approved by jackh726

It is now in the queue for this repository.

[compiler-errors]

For the record, this is a functional change in the case that we have an additional type error inside one of the args.

[oli-obk]

This PR and #105281 have the same diagnostic output on

fn main() -> Result<(), ()> {
    a(b(c(d(e(
        //~^ ERROR cannot find function `a` in this scope
        //~| ERROR cannot find function `b` in this scope
        //~| ERROR cannot find function `c` in this scope
        //~| ERROR cannot find function `d` in this scope
        //~| ERROR cannot find function `e` in this scope
        z????????????????????????????????????????????????????????????????????????????????????????
        ?????????????????????????????????????????????????????????????????????????????????????????
        ??????????????????????????????????????????????????????????????????
        //~^^^ ERROR cannot find value `z` in this scope
    )))))
}

[compiler-errors]

This PR and #105281 have the same diagnostic output on [...]

That's actually just a coincidence of the extra check_expr call we do in suggest_call_as_method. We still unnecessarily skip checking later expressions for errors, for example:

fn main() -> Result<(), ()> {
    a(1, 1i32 == 2u32)
}

Goes from beta:

error[[E0425]](https://doc.rust-lang.org/beta/error-index.html#E0425): cannot find function `a` in this scope
 --> src/main.rs:2:5
  |
2 |     a(1, 1i32 == 2u32)
  |     ^ not found in this scope

error[[E0308]](https://doc.rust-lang.org/beta/error-index.html#E0308): mismatched types
 --> src/main.rs:2:18
  |
2 |     a(1, 1i32 == 2u32)
  |                  ^^^^ expected `i32`, found `u32`

error[[E0277]](https://doc.rust-lang.org/beta/error-index.html#E0277): can't compare `i32` with `u32`
 --> src/main.rs:2:15
  |
2 |     a(1, 1i32 == 2u32)
  |               ^^ no implementation for `i32 == u32`
  |
  = help: the trait `PartialEq<u32>` is not implemented for `i32`
  = help: the following other types implement trait `PartialEq<Rhs>`:
            <i32 as PartialEq<serde_json::Value>>
            <i32 as PartialEq<serde_yaml::Value>>
            <i32 as PartialEq>

To nightly:

error[[E0425]](https://doc.rust-lang.org/nightly/error-index.html#E0425): cannot find function `a` in this scope
 --> src/main.rs:2:5
  |
2 |     a(1, 1i32 == 2u32)
  |     ^ not found in this scope

I'm not happy that we do that, so I'll resurrect #105281 which calls check_expr properly on these arguments. I might also revert #106039 in that PR, since the only reason we need to return a ty_error is because we're not checking all of the arg expressions correctly...