Use GitHub yaml templates for ICE, Docs and Diagnostics tickets #106831
Conversation
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
estebank
force-pushed
the
tickets_yaml
branch
from
6adf6f8
to
b5f7cba
Compare
estebank
changed the title
|
You can see what this will look like by navigating from https://github.com/estebank/rust-issue-template-test/issues/new/choose This is the doc for the "issue forms" feature https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms |
estebank
force-pushed
the
tickets_yaml
branch
from
b5f7cba
to
a1614d0
Compare
|
Not opposed to trying this! I know required form inputs can be annoying when filing issues though, but we already have alternatives and users can always opt-out, so it's probably OK. @bors r+ rollup |
bors
added
S-waiting-on-bors
…lacrum Use GitHub yaml templates for ICE, Docs and Diagnostics tickets The GitHub yaml templates allow us to define HTML forms with validation for issue templates, instead of the current markdown based templates which only let us introduce text into the user editable text area. The form lets us make some fields mandatory, as well as add text that won't pollute the user's text and titles that won't be interfered with by enterprising users.
…lacrum Use GitHub yaml templates for ICE, Docs and Diagnostics tickets The GitHub yaml templates allow us to define HTML forms with validation for issue templates, instead of the current markdown based templates which only let us introduce text into the user editable text area. The form lets us make some fields mandatory, as well as add text that won't pollute the user's text and titles that won't be interfered with by enterprising users.
| id: code | ||
| attributes: | ||
| label: Code | ||
| description: Please provide code or a link to a repository that can reproduce the problem |
There was a problem hiding this comment.
| description: Please provide code or a link to a repository that can reproduce the problem | |
| description: Please provide code, [playground[(https://play.rust-lang.org/) link or a link to a repository that can reproduce the problem |
I'd like to nudge people to reproduce on the playground :)
There was a problem hiding this comment.
Yes! Please send a follow up PR!
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#106046 (Fix mir-opt tests for big-endian platforms) - rust-lang#106470 (tidy: Don't include wasm32 in compiler dependency check) - rust-lang#106566 (Emit a single error for contiguous sequences of unknown tokens) - rust-lang#106644 (Update the wasi-libc used for the wasm32-wasi target) - rust-lang#106665 (Add note when `FnPtr` vs. `FnDef` impl trait) - rust-lang#106752 (Emit a hint for bad call return types due to generic arguments) - rust-lang#106788 (Tweak E0599 and elaborate_predicates) - rust-lang#106831 (Use GitHub yaml templates for ICE, Docs and Diagnostics tickets) - rust-lang#106846 (Improve some comments and names in parser) - rust-lang#106848 (Fix wrong path in triage bot autolabel for wg-trait-solver-refactor) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
Hello, |
|
@albertlarsan68 Does GitHub Mobile not open an embedded browser for them to work? If so, that's quite a bad user experience :-/ This should be a consideration, but I am hesitant to revert the changes for ICEs in particular because I'm failing to picture a situation where someone encounters one in a device where the user is also needing to file the report using GitHub Mobile. |
|
It seems like it is one of the few cases where it doesn't work, while for other links it opens them in an embedded browser. |
|
@albertlarsan68 does it at least give a reasonable error? I want to figure out how quickly we need to come to a decision for changes. |
|
It is not an error, just that it opens in the "external" browser, and not an embedded browser. |
… r=Mark-Simulacrum Include both md and yaml ICE ticket templates * Existing compilers link to the md version * The YAML version field for the backtrace *doesn't let us paste a full backtrace* * We will need the YAML version in order to be able to submit reports once we start storing the backtrace to disk Follow up to rust-lang#106831. Reaction to rust-lang#106874, which made me realize that *really* long backtraces are rejected by GitHub Forms. A single backtrace won't hit this, but ICEs sometimes compound.
… r=Mark-Simulacrum Include both md and yaml ICE ticket templates * Existing compilers link to the md version * The YAML version field for the backtrace *doesn't let us paste a full backtrace* * We will need the YAML version in order to be able to submit reports once we start storing the backtrace to disk Follow up to rust-lang#106831. Reaction to rust-lang#106874, which made me realize that *really* long backtraces are rejected by GitHub Forms. A single backtrace won't hit this, but ICEs sometimes compound.
The GitHub yaml templates allow us to define HTML forms with validation for issue templates, instead of the current markdown based templates which only let us introduce text into the user editable text area. The form lets us make some fields mandatory, as well as add text that won't pollute the user's text and titles that won't be interfered with by enterprising users.