Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include both md and yaml ICE ticket templates #106898

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Include both md and yaml ICE ticket templates #106898

merged 1 commit into from
Feb 1, 2023

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Jan 15, 2023 •
edited
Loading

  • Existing compilers link to the md version
  • The YAML version field for the backtrace doesn't let us paste a full backtrace
  • We will need the YAML version in order to be able to submit reports once we start storing the backtrace to disk

Follow up to #106831. Reaction to #106874, which made me realize that really long backtraces are rejected by GitHub Forms. A single backtrace won't hit this, but ICEs sometimes compound.

@estebank
Include both md and yaml ICE ticket templates
f706c3c 
* Existing compilers link to the md version
* The YAML version field for the backtrace *doesn't let us paste a full backtrace*
* We will need the YAML version in order to be able to submit reports once we start storing the backtrace to disk
@rustbot
Copy link
Collaborator

rustbot commented Jan 15, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 15, 2023
@Mark-Simulacrum
Copy link
Member

r=me, but I'm confused about keeping both. Isn't that likely to be confusing for users?

@estebank
Copy link
Contributor Author

@Mark-Simulacrum it is (which is why I removed the previous one), but there are conflicting desires here:

  • I want to use the yaml ones because they support querystring fields, which means that I can customize the url printed by the compiler to prefill everything (but the actual backtrace, which is unfortunately too long)
  • Old versions of rustc will continue printing the old URL for a long while
  • We just had a case of a really long backtrace that wasn't accepted by the form

An option would be to make the yaml one into "Automatic ICE" or "Tool Only ICE report" or something like this.

I'm not happy with this situation, and if I didn't dislike the md templates because of how unintuitive they can be I'd be reverting outright.

@Mark-Simulacrum
Copy link
Member

An option would be to make the yaml one into "Automatic ICE" or "Tool Only ICE report" or something like this.

I think this would be my preference, personally, if we expect it to be primarily used by the auto-filled link.

@Noratrieb Noratrieb mentioned this pull request Jan 21, 2023
Closed
@Mark-Simulacrum
Copy link
Member

@rustbot author (not sure if you want to go ahead here or not)

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2023
@Noratrieb Noratrieb mentioned this pull request Jan 25, 2023
Closed
@estebank
Copy link
Contributor Author

@bors r=Mark-Simulacrum

Lets merge this now because it is causing trouble to users. I will be unavailable for another couple of weeks, I had to deal with a sudden personal issue. Would you mind following up on this @Mark-Simulacrum?

@bors
Copy link
Contributor

bors commented Jan 30, 2023

📌 Commit f706c3c has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 30, 2023
@Mark-Simulacrum
Copy link
Member

I'll try to add it to my list.

@jyn514
Copy link
Member

jyn514 commented Jan 31, 2023

@bors rollup

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 31, 2023
@GuillaumeGomez
Rollup merge of rust-lang#106898 - estebank:ice-forms-are-a-headache,…
25961ba 
… r=Mark-Simulacrum

Include both md and yaml ICE ticket templates

* Existing compilers link to the md version
* The YAML version field for the backtrace *doesn't let us paste a full backtrace*
* We will need the YAML version in order to be able to submit reports once we start storing the backtrace to disk

Follow up to rust-lang#106831. Reaction to rust-lang#106874, which made me realize that *really* long backtraces are rejected by GitHub Forms. A single backtrace won't hit this, but ICEs sometimes compound.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 31, 2023
Closed
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 31, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 1, 2023
@bors
Auto merge of rust-lang#107536 - GuillaumeGomez:rollup-xv7dx2h, r=Gui…
ad8e1dc 
…llaumeGomez

Rollup of 12 pull requests

Successful merges:

 - rust-lang#106898 (Include both md and yaml ICE ticket templates)
 - rust-lang#107331 (Clean up eslint annotations and remove unused JS function)
 - rust-lang#107348 (small refactor to new projection code)
 - rust-lang#107354 (rustdoc: update Source Serif 4 from 4.004 to 4.005)
 - rust-lang#107412 (avoid needless checks)
 - rust-lang#107467 (Improve enum checks)
 - rust-lang#107486 (Track bound types like bound regions)
 - rust-lang#107491 (rustdoc: remove unused CSS from `.setting-check`)
 - rust-lang#107508 (`Edition` micro refactor)
 - rust-lang#107525 (PointeeInfo is advisory only)
 - rust-lang#107527 (rustdoc: stop making unstable items transparent)
 - rust-lang#107535 (Replace unwrap with ? in TcpListener doc)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b9b5676 into rust-lang:master Feb 1, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 1, 2023
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Feb 7, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 8, 2023
@matthiaskrgr
Rollup merge of rust-lang#107773 - Mark-Simulacrum:rename-auto-templa…
ff34c06 
…te, r=estebank

Clearly signal purpose of the yaml template

Following up on rust-lang#106898 (comment)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 8, 2023
@matthiaskrgr
Rollup merge of rust-lang#107773 - Mark-Simulacrum:rename-auto-templa…
a4a164c 
…te, r=estebank

Clearly signal purpose of the yaml template

Following up on rust-lang#106898 (comment)
@estebank estebank deleted the ice-forms-are-a-headache branch November 9, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@estebank @rustbot @Mark-Simulacrum @bors @jyn514