Make stage2 rustdoc and proc-macro-srv disableable in x.py install #106886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
T-bootstrap
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 23, 2023
Rollup of 7 pull requests Successful merges: - rust-lang#106796 (BPF: Disable atomic CAS) - rust-lang#106886 (Make stage2 rustdoc and proc-macro-srv disableable in x.py install) - rust-lang#107101 (Filter param-env predicates for errors before calling `to_opt_poly_trait_pred`) - rust-lang#107109 (ThinBox: Add intra-doc-links for Metadata) - rust-lang#107148 (remove error code from `E0789`, add UI test/docs) - rust-lang#107151 (Instantiate dominators algorithm only once) - rust-lang#107153 (Consistently use dominates instead of is_dominated_by) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
Just to leave a breadcrumb for anyone running into this down the line: the way you (may) run into this if you build your own Rust from source and previously specified The fix is to add |
|
It may(?) be worth adding this to the "Compatibility Notes" section in the Rust changelog. Took me a while to trace the issue back to this PR. |
Mark-Simulacrum
added
the
relnotes
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Apr 22, 2023
…=cuviper Add note about change in bootstrap defaults Not a huge fan of the proposed wording, open to changes in that. Per rust-lang#106886 (comment). cc `@jonhoo` r? `@cuviper` perhaps?
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 23, 2023
…=cuviper Add note about change in bootstrap defaults Not a huge fan of the proposed wording, open to changes in that. Per rust-lang#106886 (comment). cc `@jonhoo` r? `@cuviper` perhaps?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rustdoc will build if
[build] tools = ["rustdoc"]is set, and rust-analyzer-proc-macro-srv will build if[build] tools = ["rust-analyzer"]is set.On my machine skipping these tools speeds up
x.py installfrom 7m15s to 6m08s (0m43s for rustdoc and 0m24s for rust-analyzer-proc-macro-srv). This is a significant speedup, since I never use rust-analyzer-proc-macro-srv, and I practically never need to use a custom build of rustdoc.