Output tree representation on thir-tree #107006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jackh726 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
I like this a lot. Needs tests blessed though. Maybe we should keep the old behavior, like |
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
@compiler-errors Addressed your points. |
|
@rustbot review |
rustbot
added
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 29, 2023
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#96763 (Fix maintainer validation message) - rust-lang#106540 (Insert whitespace to avoid ident concatenation in suggestion) - rust-lang#106763 (print why a test was ignored if its the only test specified) - rust-lang#106769 (libtest: Print why a test was ignored if it's the only test specified.) - rust-lang#106798 (Implement `signum` with `Ord`) - rust-lang#107006 (Output tree representation on thir-tree) - rust-lang#107078 (Update wording of invalid_doc_attributes docs.) - rust-lang#107169 (Pass `--locked` to the x test tidy call) - rust-lang#107431 (docs: remove colon from time header) - rust-lang#107432 (rustdoc: remove unused class `has-srclink`) - rust-lang#107448 (When stamp doesn't exist, should say Error, and print path to stamp file) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 27, 2023
Move THIR printing to rustc_mir_build. rust-lang#107451 increased the compilation time of `rustc_middle` by 10% = 3s. As rust-lang#107006 adds quite a lot of code to rustc_middle, I suspect it to be the cause. This PR moves the THIR printing code to `rustc_mir_build`, where the query provider lives, in order to benefit from higher parallelism when compiling rustc.
saethlin
pushed a commit
to saethlin/miri
that referenced
this pull request
Mar 5, 2023
Move THIR printing to rustc_mir_build. rust-lang/rust#107451 increased the compilation time of `rustc_middle` by 10% = 3s. As rust-lang/rust#107006 adds quite a lot of code to rustc_middle, I suspect it to be the cause. This PR moves the THIR printing code to `rustc_mir_build`, where the query provider lives, in order to benefit from higher parallelism when compiling rustc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current output of
-Zunpretty=thir-treeis really cumbersome to work with, using an actual tree representation should make it easier to see what the thir looks like.