Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix maintainer validation message #96763

Merged
merged 1 commit into from
Jan 29, 2023
Merged

Fix maintainer validation message #96763

merged 1 commit into from
Jan 29, 2023

Conversation

Abdur-rahmaanJ
Copy link
Contributor

State clearly why maintainer verification is not activating, ruling out the user thinking they misconfigured something.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 6, 2022
@Mark-Simulacrum
Copy link
Member

I think we should likely follow up here and just delete that code, rather than adjusting the specific print message.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2022
@Abdur-rahmaanJ
Copy link
Contributor Author

@Mark-Simulacrum deleted related codes

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 7, 2022
Mark-Simulacrum
Mark-Simulacrum reviewed May 7, 2022
View reviewed changes
src/tools/publish_toolstate.py
# to be removed since we are probably not going to use an admin
# token, and I don't see another way to do this.
print('maintainer validation disabled')
# validate_maintainers(repo, github_token)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the validate_maintainers function is now also dead code?

@Mark-Simulacrum
Copy link
Member

Please also squash commits after fixing this nit, and then we can move ahead.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2022
@JohnCSimon
Copy link
Member

@Abdur-rahmaanJ - can you squash the commits?

FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.

@apiraino apiraino added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label May 23, 2022
@JohnCSimon
Copy link
Member

@Abdur-rahmaanJ
Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.
Note: if you do please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.
Thanks for your contribution.

@rustbot label: +S-inactive

@JohnCSimon JohnCSimon closed this Jun 19, 2022
@rustbot rustbot added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Jun 19, 2022
@Abdur-rahmaanJ
Copy link
Contributor Author

@JohnCSimon Oh i missed this conversation entirely. Do i need some bot commands to re-open the PR?

@Abdur-rahmaanJ
Copy link
Contributor Author

I think i don't have the rights to re-open the PR

@Abdur-rahmaanJ
Copy link
Contributor Author

@Mark-Simulacrum In case you can open it, thanks in advance.

@Mark-Simulacrum Mark-Simulacrum removed the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Jan 17, 2023
@rustbot rustbot added the A-testsuite Area: The testsuite used to check the correctness of rustc label Jan 17, 2023
@Abdur-rahmaanJ
Copy link
Contributor Author

@Mark-Simulacrum I think it's ok now

@Mark-Simulacrum
Copy link
Member

@rustbot ready

You can use this command too, by the way.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 17, 2023
@Mark-Simulacrum
Copy link
Member

https://github.com/rust-lang/rust/pull/96763/files#r867352121 seems unresolved still -- we should clean up by deleting the validate_maintainers function, presuming it's unused.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2023
@Abdur-rahmaanJ
fix maintainer validation message
2fe58b9 
fix remove token check for maintainers
fix: rm validate_maintainers function
@Abdur-rahmaanJ
Copy link
Contributor Author

@Mark-Simulacrum Sorry, now it should be resolved!

@Abdur-rahmaanJ
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 22, 2023
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 29, 2023

📌 Commit 2fe58b9 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 29, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2023
@bors
Auto merge of rust-lang#107451 - matthiaskrgr:rollup-m4ucfu8, r=matth…
e972bc8 
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#96763 (Fix maintainer validation message)
 - rust-lang#106540 (Insert whitespace to avoid ident concatenation in suggestion)
 - rust-lang#106763 (print why a test was ignored if its the only test specified)
 - rust-lang#106769 (libtest: Print why a test was ignored if it's the only test specified.)
 - rust-lang#106798 (Implement `signum` with `Ord`)
 - rust-lang#107006 (Output tree representation on thir-tree)
 - rust-lang#107078 (Update wording of invalid_doc_attributes docs.)
 - rust-lang#107169 (Pass `--locked` to the x test tidy call)
 - rust-lang#107431 (docs: remove colon from time header)
 - rust-lang#107432 (rustdoc: remove unused class `has-srclink`)
 - rust-lang#107448 (When stamp doesn't exist, should say Error, and print path to stamp file)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 309fb19 into rust-lang:master Jan 29, 2023
@rustbot rustbot added this to the 1.69.0 milestone Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Abdur-rahmaanJ @rust-highfive @Mark-Simulacrum @JohnCSimon @bors @apiraino @rustbot