Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ObligationCtxt::new_in_snapshot in satisfied_from_param_env #107479

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Use ObligationCtxt::new_in_snapshot in satisfied_from_param_env #107479

merged 1 commit into from
Jan 31, 2023

Conversation

compiler-errors
Copy link
Member

We can evaluate nested ConstEvaluatable obligations in an evaluation probe, which will ICE if we use ObligationCtxt::new.

Fixes #107474
Fixes #106666

r? @BoxyUwU but feel free to reassign
cc @JulianKnodt who i think added this assertion code

Not sure if the rustdoc test is needed, but can't hurt. They're the same root cause, though.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 30, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 30, 2023

Some changes occurred in const_evaluatable.rs

cc @BoxyUwU

@BoxyUwU
Copy link
Member

BoxyUwU commented Jan 31, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 31, 2023

📌 Commit 343a359 has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2023
@BoxyUwU BoxyUwU added the A-const-generics Area: const generics (parameters and arguments) label Jan 31, 2023
@JohnTitor JohnTitor mentioned this pull request Jan 31, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 31, 2023
@bors
Auto merge of rust-lang#107498 - JohnTitor:rollup-2i6g4uk, r=JohnTitor
7c4a9a9 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#107245 (Implement unsizing in the new trait solver)
 - rust-lang#107445 (Remove `GenFuture` from core)
 - rust-lang#107473 (Update books)
 - rust-lang#107476 (rustdoc: remove unnecessary wrapper `div.item-decl` from HTML)
 - rust-lang#107477 (Migrate last part of CSS themes to CSS variables)
 - rust-lang#107479 (Use `ObligationCtxt::new_in_snapshot` in `satisfied_from_param_env`)
 - rust-lang#107482 (rustdoc: remove meta keywords from HTML)
 - rust-lang#107494 (fix link in std::path::Path::display())

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f95f835 into rust-lang:master Jan 31, 2023
@rustbot rustbot added this to the 1.69.0 milestone Jan 31, 2023
@compiler-errors compiler-errors deleted the probe-can-call-ocx branch August 11, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BoxyUwU BoxyUwU

Labels
A-const-generics Area: const generics (parameters and arguments) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
4 participants
@compiler-errors @rustbot @BoxyUwU @bors