Tighter spans for bad inherent impl self types
#107942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Nilstrieb (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Noratrieb
reviewed
Feb 11, 2023
tests/ui/error-codes/E0116.stderr
Outdated
| | | ||
| LL | impl Vec<u8> {} | ||
| | ^^^^^^^^^^^^^^^ impl for type defined outside of crate. | ||
| | ^^^^^^^ impl for type defined outside of crate. |
There was a problem hiding this comment.
I would prefer it if it also pointed at the impl keyword (impl.start..ty.end) to emphasize that the impl is wrong and not just something about the type like it being not found.
compiler-errors
force-pushed
the
tighter-inherent-impl-bad-spans
branch
from
ff7d5ef
to
8570b76
Compare
Noratrieb
approved these changes
Feb 12, 2023
compiler-errors
force-pushed
the
tighter-inherent-impl-bad-spans
branch
from
8570b76
to
e20f6ff
Compare
|
@bors r=Nilstrieb rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 13, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#107902 (fix: improve the suggestion on future not awaited) - rust-lang#107913 (Update broken link in cargo style guide) - rust-lang#107942 (Tighter spans for bad inherent `impl` self types) - rust-lang#107948 (Allow shortcuts to directories to be used for ./x.py fmt) - rust-lang#107971 (Clearly document intentional UB in mir-opt tests) - rust-lang#107985 (Added another error to be processed in fallback) - rust-lang#108002 (Update books) - rust-lang#108013 (rustdoc: use a string with one-character codes for search index types) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 15, 2023
Avoid accessing HIR when it can be avoided Experiment to see if it helps some incremental cases. Will be rebased once rust-lang#107942 gets merged. r? `@ghost`
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Feb 16, 2023
Avoid accessing HIR when it can be avoided Experiment to see if it helps some incremental cases. Will be rebased once rust-lang/rust#107942 gets merged. r? `@ghost`
Jarcho
pushed a commit
to Jarcho/rust-clippy
that referenced
this pull request
Feb 25, 2023
Avoid accessing HIR when it can be avoided Experiment to see if it helps some incremental cases. Will be rebased once rust-lang/rust#107942 gets merged. r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-explanatory